Page MenuHomePhabricator

[Lockdown] Breaks MediaWiki Search including Numbers
Closed, ResolvedPublic

Description

Author: zrhwiki

Description:
Working version of Lockdown extension

The latest SVN version of the Lockdown extension used with the latest SVN version of MediaWiki blocks some MediaWiki searches.

Step by step:

  1. Install latest SVN version of MediaWiki and the Lockdown extension (trunk)
  2. Enter a search term including a number, e.g. 'a380'

Expected result:

Search results

Actual result:

White page

Workaround:

Older versions of Lockdown do not cause the problem.


Version: unspecified
Severity: major

Attached:

Details

Reference
bz23084

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:10 PM
bzimport set Reference to bz23084.
bzimport added a subscriber: Unknown Object (MLST).

zrhwiki wrote:

Latest SVN version of Lockdown extension

Attached:

Just removing the crashing function is not an option. By the way, next time please submit patches as unified diffs, otherwise it'll be almost impossible to review.

I tried to reproduce the error, but discovered nothing. Please follow http://www.mediawiki.org/wiki/Manual:Errors_and_Symptoms#You_see_a_Blank_Page to find out the details of the error and post them here, also please attach part of your LocalSettings.php related to Lockdown.

zrhwiki wrote:

(In reply to comment #3)

I tried to reproduce the error, but discovered nothing. Please follow
http://www.mediawiki.org/wiki/Manual:Errors_and_Symptoms#You_see_a_Blank_Page
to find out the details of the error and post them here,

I receive the following error message:

Fatal error: Cannot break/continue 1 level in /home/…/w/extensions/Lockdown/Lockdown.php on line 164

also please attach
part of your LocalSettings.php related to Lockdown.

require_once("$IP/extensions/Lockdown/Lockdown.php" );
$wgSpecialPageLockdown['Export'] = array('sysop');
$wgSpecialPageLockdown['Statistics'] = array('sysop');

zrhwiki wrote:

(In reply to comment #2)

Just removing the crashing function is not an option. By the way, next time
please submit patches as unified diffs, otherwise it'll be almost impossible to
review.

Wilco! :)

(Thank you for your help, I appreciate it!)

ZRHwiki: Is that still an issue in recent versions?

C'ing the maintainer.