Page MenuHomePhabricator
Create Task
Maniphest T250852

noc.wikimedia.org incorrect raw file urls
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

  1. Open https://noc.wikimedia.org/conf/highlight.php?file=dblists/all.dblist
  2. Click "raw file"

Expected behavior
This should open https://noc.wikimedia.org/conf/dblists/all.dblist

Current behavior
It opens https://noc.wikimedia.org/conf/dblists/all.dblist.txt (HTTP 404)

Pinging @Aklapper (superfluous I know) as he last touched the line of code

Details

SubjectRepoBranchLines +/-
noc: Fix highlight.php to not append .txt to dblist URLsoperations/mediawiki-configmaster+7 -10
Customize query in gerrit

Related Objects

Event Timeline

Dvorapa created this task.Apr 21 2020, 7:36 PM
Dvorapa updated the task description. (Show Details)
Dvorapa added a subscriber: Urbanecm.EditedApr 21 2020, 7:39 PM

It seems in some cases .txt is needed and in some cases .txt is unwanted: T227606

gerritbot added a comment.Apr 21 2020, 8:42 PM

Change 591459 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] noc.wikimedia.org: highlight.php should not append .txt to dblist URLs

https://gerrit.wikimedia.org/r/591459

gerritbot added a project: Patch-For-Review.Apr 21 2020, 8:42 PM
Urbanecm claimed this task.Apr 21 2020, 8:42 PM

Makes sense.

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptApr 21 2020, 8:42 PM
Urbanecm moved this task from Backlog to To deploy on the User-Urbanecm board.Apr 25 2020, 10:22 PM
Urbanecm moved this task from To deploy to Waiting on review on the User-Urbanecm board.Apr 27 2020, 4:17 PM
gerritbot added a comment.May 3 2020, 10:41 PM

Change 591459 merged by jenkins-bot:
[operations/mediawiki-config@master] noc: Fix highlight.php to not append .txt to dblist URLs

https://gerrit.wikimedia.org/r/591459

Urbanecm closed this task as Resolved.May 3 2020, 11:04 PM
Maintenance_bot removed a project: Patch-For-Review.May 3 2020, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL