Add support for 'skinScripts' in extension.json and skin.json
Open, HighPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Apr 21 2020, 7:36 PM

Description

ResourceLoader supports skinStyles and a lesser known skinScripts.

For skinStyles, the the ResourceModuleSkinStyles attribute can be used by skins in skin.json to specify skins to add to existing modules, however there is no equivalent for skinScripts (e.g. "ResourceModuleSkinScripts")

Note: See T251957 - it's likely skinScripts would not have any impact on modules using packageFiles.

Related Objects

Mentioned In: T291433: Relocate styles from new mediawiki.diff.styles module
T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped
T249051: [Spike 12.75 hrs] Where does the application-specific Vue.js search code live and what impact does this decision have on the long term?
Mentioned Here: T251957: skinScripts cannot be used alongside packageFiles: should throw exception.

Event Timeline

Jdlrobson created this task.Apr 21 2020, 7:36 PM

Jdlrobson mentioned this in T249051: [Spike 12.75 hrs] Where does the application-specific Vue.js search code live and what impact does this decision have on the long term?.Apr 21 2020, 8:04 PM

Jony subscribed.Apr 22 2020, 7:01 AM

Krinkle triaged this task as High priority.Apr 27 2020, 7:47 PM

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.

Krinkle moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.

• Niedzielski added a project: Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)).May 6 2020, 2:19 PM

• nray subscribed.May 6 2020, 8:18 PM

Jdlrobson removed projects: Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)), Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4), Vector 2022.May 6 2020, 9:02 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson removed a parent task: T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.May 8 2020, 4:35 PM

Krinkle renamed this task from Add support for ResourceLoaderScriptModule in extension.json and skin.json to Add support for 'skinStyles' in extension.json and skin.json.May 11 2020, 5:14 PM

Krinkle updated the task description. (Show Details)

Krinkle renamed this task from Add support for 'skinStyles' in extension.json and skin.json to Add support for 'skinScripts' in extension.json and skin.json.May 11 2020, 5:17 PM

Krinkle mentioned this in T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.May 11 2020, 5:21 PM

Krinkle moved this task from To-do: Goals prioritized current Quarter to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.Jun 22 2020, 7:58 PM

I've removed the workaround from the task description as that is not acceptable production code, in case someone finds it as example without the necessary context.

Krinkle mentioned this in T291433: Relocate styles from new mediawiki.diff.styles module.Oct 5 2021, 8:22 PM

In T250853#7403668, @Krinkle wrote:

I've removed the workaround from the task description as that is not acceptable production code, in case someone finds it as example without the necessary context.

Rather than remove it, it might make sense to restore it but make clear that's unacceptable so there's no room for interpretation :).

Jdlrobson unsubscribed.Oct 5 2021, 9:09 PM

Krinkle moved this task from To-do: Goals, prioritized next 4 Quarters to Backlog: Maintenance, non-prioritized on the Performance-Team board.Oct 4 2022, 6:49 PM

Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed Performance-Team.Mar 18 2024, 10:12 PM

Krinkle removed subscribers: • nray, • Niedzielski.

Add support for 'skinScripts' in extension.json and skin.jsonOpen, HighPublicActions

Description

Related Objects

Event Timeline

Add support for 'skinScripts' in extension.json and skin.json
Open, HighPublic
Actions