Page MenuHomePhabricator
Create Task
Maniphest T250881

Phabricator upgrade broke Vector CI - cannot access RAW text
Closed, ResolvedPublic
Actions

Description

Vector relies on raw assets to build documentation as part of one of its CI steps. Previously it was using github but migrated to Phabricator after being told that we should dog food our own tools.

This historically has come from a URI in Phabricator such as "https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.less/mediawiki.mixins.less?view=raw"

This no longer works for some reason, redirecting to
https://phabricator.wikimedia.org/file/view/31771082/source/

This means all Vector patches are blocked by CI for now.

Short term fix: disable the job
Longer term fix: Please provide a stable URI for accessing raw assets from repos.

(I'll be back to this on Monday!)

Details

SubjectRepoBranchLines +/-
Load files from gerrit not phabmediawiki/skins/Vectormaster+4 -4
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 22 2020, 12:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2020, 12:21 AM
Jdlrobson triaged this task as Unbreak Now! priority.Apr 22 2020, 12:22 AM

I'm guessing blocking patches to our main skin might be UBN worthy and block any SWAT deploys so I wanted to make sure those impacted were aware of it :) - feel free to drop to high once aware.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 22 2020, 12:22 AM
Jdlrobson renamed this task from Phabricator upgrade broke Vector CI to Phabricator upgrade broke Vector CI - cannot access RAW text.Apr 22 2020, 12:23 AM
Reedy subscribed.Apr 22 2020, 1:48 AM

Use gerrit? Considering Phab is not canonical either, and we develop against gerrit?

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/resources/src/mediawiki.less/mediawiki.mixins.less?format=TEXT

gerritbot added a comment.Apr 22 2020, 1:51 AM

Change 591580 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/Vector@master] Load files from gerrit not phab

https://gerrit.wikimedia.org/r/591580

gerritbot added a project: Patch-For-Review.Apr 22 2020, 1:51 AM
gerritbot added a comment.Apr 22 2020, 4:51 AM

Change 591580 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Load files from gerrit not phab

https://gerrit.wikimedia.org/r/591580

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 22 2020, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 22 2020, 5:10 AM
Jdlrobson closed this task as Resolved.Apr 22 2020, 5:20 AM
Jdlrobson claimed this task.

Thanks. Hadn't thought to use base64 on the raw assets. Bit weird but works!

Reedy claimed this task.Apr 22 2020, 3:39 PM
• Edd0408 set Due Date to Apr 23 2020, 12:00 AM.Apr 23 2020, 8:35 AM
Billinghurst added subscribers: • Edd0408, Billinghurst.Apr 23 2020, 8:47 AM

@Edd0408 These edits do not seem to be useful or correct, can I suggest that you desist, or seek guidance in the use of phabricator

Aklapper removed Due Date.Apr 23 2020, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL