Page MenuHomePhabricator

RemexHTML PHP 7.4 failures
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/RemexHtml/+/592170/
https://integration.wikimedia.org/ci/job/composer-package-php74-docker/609/console

I won't paste them all, but...

03:11:36 There were 13268 errors:
03:11:36 
03:11:36 1) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: PLAINTEXT content model flag" ('PLAINTEXT state', 'plaintext', '<head>&body;', array(array('Character', '<head>&body;')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 2) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (RCDATA state)" ('RCDATA state', 'xmp', 'foo</xmp>', array(array('Character', 'foo'), array('EndTag', 'xmp')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 3) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (RAWTEXT state)" ('RAWTEXT state', 'xmp', 'foo</xmp>', array(array('Character', 'foo'), array('EndTag', 'xmp')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 4) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (case-insensitivity) (RCDATA state)" ('RCDATA state', 'xmp', 'foo</xMp>', array(array('Character', 'foo'), array('EndTag', 'xmp')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 5) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (case-insensitivity) (RAWTEXT state)" ('RAWTEXT state', 'xmp', 'foo</xMp>', array(array('Character', 'foo'), array('EndTag', 'xmp')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 6) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (ending with space) (RCDATA state)" ('RCDATA state', 'xmp', 'foo</xmp ', array(array('Character', 'foo'), 'ParseError'))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 7) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (ending with space) (RAWTEXT state)" ('RAWTEXT state', 'xmp', 'foo</xmp ', array(array('Character', 'foo'), 'ParseError'))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 8) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (ending with EOF) (RCDATA state)" ('RCDATA state', 'xmp', 'foo</xmp', array(array('Character', 'foo</xmp')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 9) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (ending with EOF) (RAWTEXT state)" ('RAWTEXT state', 'xmp', 'foo</xmp', array(array('Character', 'foo</xmp')))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135
03:11:36 
03:11:36 10) RemexHtml\Tokenizer\TokenizerTest::testDefault with data set "contentModelFlags.test: End tag closing RCDATA or RAWTEXT (ending with slash) (RCDATA state)" ('RCDATA state', 'xmp', 'foo</xmp/', array(array('Character', 'foo'), 'ParseError'))
03:11:36 Trying to access array offset on value of type bool
03:11:36 
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:111
03:11:36 /src/tests/phpunit/Tokenizer/TokenizerTest.php:135

Event Timeline

Reedy created this task.Apr 23 2020, 2:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2020, 2:26 AM
Reedy updated the task description. (Show Details)Apr 23 2020, 2:29 AM

Change 592185 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/libs/RemexHtml@master] Add phan configuration and make Remex pass

https://gerrit.wikimedia.org/r/592185

Change 592185 merged by jenkins-bot:
[mediawiki/libs/RemexHtml@master] Add phan configuration and make Remex pass

https://gerrit.wikimedia.org/r/592185

Reedy closed this task as Resolved.Apr 28 2020, 12:25 AM
Reedy assigned this task to cscott.

Well, probably not fully resolved until I tag and release Remex and bump the required versions in core (and Parsoid?), but we're certainly getting there...

Change 593328 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Update wikimedia/remex-html to v2.2.0

https://gerrit.wikimedia.org/r/593328

Change 593329 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Update wikimedia/remex-html to v2.2.0

https://gerrit.wikimedia.org/r/593329

Change 593325 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Bump version of Remex to v2.2.0

https://gerrit.wikimedia.org/r/593325

Change 593328 merged by jenkins-bot:
[mediawiki/vendor@master] Update wikimedia/remex-html to v2.2.0

https://gerrit.wikimedia.org/r/593328

Change 593329 merged by jenkins-bot:
[mediawiki/core@master] Update wikimedia/remex-html to v2.2.0

https://gerrit.wikimedia.org/r/593329

Change 593325 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Bump version of Remex to v2.2.0 (bump zest and alea as well)

https://gerrit.wikimedia.org/r/593325

Change 594256 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a12

https://gerrit.wikimedia.org/r/594256

Change 594256 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a12

https://gerrit.wikimedia.org/r/594256