Page MenuHomePhabricator

SpecialBlock::getTargetAndType is called unnecessarily from several places
Closed, ResolvedPublic

Description

SpecialBlock::getTargetAndType is used to prioritize target parameters when called with a WebRequest, and simply returns DatabaseBlock::parseTarget otherwise.

In most cases it is called without the WebRequest, so callers should use DatabaseBlock::parseTarget instead.

Event Timeline

Change 592249 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Remove unnecessary calls to SpecialBlock::getTargetAndType

https://gerrit.wikimedia.org/r/592249

Change 592250 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Remove SpecialUnblock dependency on SpecialBlock::getTargetAndType

https://gerrit.wikimedia.org/r/592250

Change 592249 merged by jenkins-bot:
[mediawiki/core@master] Remove unnecessary calls to SpecialBlock::getTargetAndType

https://gerrit.wikimedia.org/r/592249

Change 592250 merged by jenkins-bot:
[mediawiki/core@master] Remove SpecialUnblock dependency on SpecialBlock::getTargetAndType

https://gerrit.wikimedia.org/r/592250

Tchanders claimed this task.