⚓ T250980 Hard deprecate Revision::getParentId

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::getParentId and ::getVisibility	mediawiki/core	master	+20 -1
Replace use of `NewRevisionFromEditComplete` hook	mediawiki/extensions/PageTriage	master	+13 -7
SpecialMobileContributions: remove all uses of Revision objects	mediawiki/extensions/MobileFrontend	master	+12 -11
Add ContribsPager::tryCreatingRevisionRecord	mediawiki/core	master	+80 -15
CategoryMembershipChangeTest: Remove use of Revision objects	mediawiki/core	master	+3 -7

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T250980 Hard deprecate Revision::getParentId

DannyS712 triaged this task as Medium priority.Apr 24 2020, 3:50 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 592327 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] CategoryMembershipChangeTest: Reduce use of Revision objects

https://gerrit.wikimedia.org/r/592327

gerritbot added a project: Patch-For-Review.Apr 24 2020, 3:51 AM

DannyS712 claimed this task.Apr 24 2020, 9:25 AM

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 26 2020, 11:37 PM

DannyS712 removed a parent task: T246284: Hard deprecate the Revision class.Apr 26 2020, 11:39 PM

DannyS712 added a parent task: T251067: Hard deprecate individual Revision class methods [tracking].

Change 592513 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

Change 592327 merged by jenkins-bot:
[mediawiki/core@master] CategoryMembershipChangeTest: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592327

Change 592785 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions: remove all uses of Revision objects

https://gerrit.wikimedia.org/r/592785

Change 592513 merged by jenkins-bot:
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

DannyS712 updated the task description. (Show Details)Apr 27 2020, 11:18 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 8:00 AM

Change 592785 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions: remove all uses of Revision objects

https://gerrit.wikimedia.org/r/592785

DannyS712 updated the task description. (Show Details)Apr 29 2020, 3:39 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 29 2020, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2020, 4:10 PM

Cannot proceed until T250338: Replace `NewRevisionFromEditComplete` with a new hook provides a replacement hook to use in PageTriage - other than PageTriage's hook handler, only uses are in core tests that will be told to ignore the deprecation when the hard deprecation is implemented

Change 598868 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Replace use of NewRevisionFromEditComplete hook

https://gerrit.wikimedia.org/r/598868

gerritbot added a project: Patch-For-Review.May 26 2020, 10:23 PM

DannyS712 changed the task status from Stalled to Open.May 26 2020, 10:59 PM

Change 598868 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace use of NewRevisionFromEditComplete hook

https://gerrit.wikimedia.org/r/598868

DannyS712 updated the task description. (Show Details)May 27 2020, 10:48 PM

Change 599135 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getParentId

https://gerrit.wikimedia.org/r/599135

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.May 27 2020, 10:52 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 27 2020, 11:00 PM

Change 599135 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getParentId and ::getVisibility

https://gerrit.wikimedia.org/r/599135