⚓ T250981 Hard deprecate Revision::getContent(Model|Handler|Format)

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+42 -2	Hard deprecate Revision::getContent(Model\|Handler\|Format)
mediawiki/core	master	+32 -17	resourceloader: Use RevisionRecord in WikiModule::invalidateModuleCache
mediawiki/core	master	+14 -4	EditPage::edit - remove use of Revision objects
mediawiki/core	master	+23 -12	RollbackAction: Reduce uses of Revision objects
mediawiki/core	master	+19 -5	SpecialComparePages: Remove use of Revision objects
mediawiki/core	master	+16 -9	FeedUtils: Remove use of Revision objects
mediawiki/core	master	+47 -30	Replace uses and hard deprecate Article::getRevisionFetched
mediawiki/core	master	+49 -30	SpecialUndelete: Make showDiff private, use RevisionRecord

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T250981 Hard deprecate Revision::getContent(Model\|Handler\|Format)

DannyS712 triaged this task as Medium priority.Apr 24 2020, 4:00 AM

DannyS712 created this task.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

Change 587904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Article::getRevisionFetched

https://gerrit.wikimedia.org/r/587904

Change 592318 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RollbackAction: Reduce uses of Revision objects

https://gerrit.wikimedia.org/r/592318

Change 591524 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialUndelete: Make showDiff private, use RevisionRecord

https://gerrit.wikimedia.org/r/591524

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 26 2020, 11:37 PM

DannyS712 removed a parent task: T246284: Hard deprecate the Revision class.Apr 26 2020, 11:39 PM

DannyS712 added a parent task: T251067: Hard deprecate individual Revision class methods [tracking].

DannyS712 renamed this task from Hard deprecate Revision::getContentHandler to Hard deprecate Revision::getContent(Model|Handler|Format).Apr 27 2020, 7:06 AM

DannyS712 updated the task description. (Show Details)

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 27 2020, 7:06 AM

Change 591524 merged by jenkins-bot:
[mediawiki/core@master] SpecialUndelete: Make showDiff private, use RevisionRecord

https://gerrit.wikimedia.org/r/591524

DannyS712 updated the task description. (Show Details)Apr 27 2020, 5:43 PM

Change 592732 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FeedUtils: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592732

Change 587904 merged by jenkins-bot:
[mediawiki/core@master] Replace uses and hard deprecate Article::getRevisionFetched

https://gerrit.wikimedia.org/r/587904

DannyS712 updated the task description. (Show Details)Apr 27 2020, 6:37 PM

Change 592736 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialComparePages: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592736

DannyS712 updated the task description. (Show Details)Apr 27 2020, 6:43 PM

DannyS712 updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 8:00 AM

Change 592732 merged by jenkins-bot:
[mediawiki/core@master] FeedUtils: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592732

Change 592736 merged by jenkins-bot:
[mediawiki/core@master] SpecialComparePages: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592736

DannyS712 updated the task description. (Show Details)May 1 2020, 7:44 PM

DannyS712 updated the task description. (Show Details)May 4 2020, 5:49 PM

Once the ResourceLoaderWikiModule::invalidateModuleCache patch merges, will send a patch following the rollback patch to make the hard deprecations (waiting for the first patch to merge to avoid merge conflicts)

Change 592318 merged by jenkins-bot:
[mediawiki/core@master] RollbackAction: Reduce uses of Revision objects

https://gerrit.wikimedia.org/r/592318

DannyS712 updated the task description. (Show Details)May 20 2020, 8:55 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).May 20 2020, 9:00 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/587571/ is the only thing blocking hard deprecation of these

Change 587571 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Use RevisionRecord in ResourceLoaderWikiModule::invalidateModuleCache

https://gerrit.wikimedia.org/r/587571

@daniel can you take a look? The patch has a -2 from @Krinkle asking Is this what typical/random code should do in order to get the content format of a revision? It seems like a lot of hard-to-get-right easy-to-forget boiler plate. Do we want to spread out and copy around this business logic? Or is/should there be a high-level thing for this? (where "this" refers to, when the main slot of a revision has no format defined, using ContentHandlerFactory::getContentHandler() for the main slot's model, and then ContentHandler::getDefaultFormat() to get the format if I'm understanding @Krinkle's concerns right)

@Krinkle fixed to use content model - can you take another look?

DannyS712 updated the task description. (Show Details)May 27 2020, 11:19 PM

Change 599138 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::edit - remove use of Revision objects

https://gerrit.wikimedia.org/r/599138

Change 599138 merged by jenkins-bot:
[mediawiki/core@master] EditPage::edit - remove use of Revision objects

https://gerrit.wikimedia.org/r/599138

DannyS712 updated the task description. (Show Details)May 28 2020, 3:31 AM

In T250981#6154039, @DannyS712 wrote:

@Krinkle fixed to use content model - can you take another look?

Change 587571 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Use RevisionRecord in WikiModule::invalidateModuleCache

https://gerrit.wikimedia.org/r/587571

Change 602188 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getContent(Model|Handler|Format)

https://gerrit.wikimedia.org/r/602188

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jun 3 2020, 11:08 PM

DannyS712 updated the task description. (Show Details)Jun 3 2020, 11:55 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).Jun 4 2020, 12:00 AM

Change 602188 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getContent(Model|Handler|Format)

https://gerrit.wikimedia.org/r/602188

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2020, 2:10 AM

DannyS712 closed this task as Resolved.Jun 4 2020, 2:13 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:14 PM