Page MenuHomePhabricator
Create Task
Maniphest T250989

Improve test coverage for SpecialBlock::processForm and SpecialUnblock::processUnblock
Closed, ResolvedPublic
Actions

Description

Ahead of work to refactor these methods, improve coverage of SpecialBlockTest::processFormErrors and add SpecialUnblockTest with tests covering processUnblock.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Introduce SpecialUnblockTest with some basic testsTchandersmediawiki/coremaster+146 -0
SpecialBlockTest: Increase coverage of SpecialBlock::processFormTchandersmediawiki/coremaster+217 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 24 2020, 9:40 AM
Tchanders mentioned this in T250737: Special:Block should not play the role of a central blocking service/utility.
Reedy added a project: Test-Coverage.Apr 24 2020, 12:00 PM
gerritbot added a comment.Apr 24 2020, 12:13 PM

Change 592404 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] SpecialBlockTest: Increase coverage of SpecialBlock::processForm

https://gerrit.wikimedia.org/r/592404

gerritbot added a project: Patch-For-Review.Apr 24 2020, 12:13 PM
gerritbot added a comment.Apr 24 2020, 6:58 PM

Change 592426 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Introduce SpecialUnblockTest with some basic tests

https://gerrit.wikimedia.org/r/592426

JJMC89 edited projects, added: MediaWiki-Blocks; removed: MediaWiki-User-management.Apr 25 2020, 6:47 PM
dbarratt added a project: Anti-Harassment-Team (The Letter Song).Apr 28 2020, 6:15 PM
dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.
Tchanders claimed this task.Apr 28 2020, 6:43 PM
gerritbot added a comment.Apr 28 2020, 7:36 PM

Change 592404 merged by jenkins-bot:
[mediawiki/core@master] SpecialBlockTest: Increase coverage of SpecialBlock::processForm

https://gerrit.wikimedia.org/r/592404

gerritbot added a comment.Apr 28 2020, 7:37 PM

Change 592426 merged by jenkins-bot:
[mediawiki/core@master] Introduce SpecialUnblockTest with some basic tests

https://gerrit.wikimedia.org/r/592426

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 28 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2020, 8:10 PM
ARamirez_WMF moved this task from Code Review 🔍 to Done: Q4 (2019-20) on the Anti-Harassment-Team (The Letter Song) board.Apr 29 2020, 4:06 PM
• Niharika closed this task as Resolved.Apr 30 2020, 6:09 PM
Tchanders merged a task: T250790: Ensure test coverage for SpecialBlock::processForm and SpecialUnblock::processUnblock is as full as possible.Oct 7 2020, 12:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits