Remove entityViewInit's dependency on entityLoaded
Closed, ResolvedPublic
Actions

Description

entityViewInit depends on the hook system and some module firing the entityLoaded hook.
The entityLoaded module does have dependencies which are not modeled in ResourceLoader and consequently expressing it as a dependency can result in a broken dependency chain (if the entityLoaded module's preconditions are not satisfied).

Details

	Subject	Repo	Branch	Lines +/-
	entityViewInit: don't express entityLoaded module dep	mediawiki/extensions/Wikibase	master	+0 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Michael	T250305 wmf-quibble-vendor-mysql-php72-docker failed on Special:EntityData
		Resolved		• Pablo-WMDE	T251007 Remove entityViewInit's dependency on entityLoaded

Event Timeline

• Pablo-WMDE created this task.Apr 24 2020, 3:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2020, 3:52 PM

Change 592416 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] entityViewInit: don't express entityLoaded module dep

https://gerrit.wikimedia.org/r/592416

gerritbot added a project: Patch-For-Review.Apr 24 2020, 3:56 PM

• Pablo-WMDE added a project: [DEPRECATED] wdwb-tech.Apr 30 2020, 7:45 AM

Hoo man wrote

This can be merged no earlier than June 3 (so that it wont be deployed earlier than 30 days after Ib676c5820 is live on Wikidata)... for good measure I suggest waiting another week, merging this on/after June 10 only.

• Pablo-WMDE mentioned this in T232459: wikibase.entityPage.entityLoaded.js runs on the main page and produces invalid request.May 7 2020, 4:37 PM

Nikki subscribed.May 10 2020, 11:53 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 9 2020, 9:13 AM

Opened https://gerrit.wikimedia.org/r/592416 for review.

Change 592416 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] entityViewInit: don't express entityLoaded module dep

https://gerrit.wikimedia.org/r/592416

Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 11 2020, 4:05 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 4:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 5:00 PM