TemplateStyles not applied in mobile talk page (overlay)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	XanonymusX
	Apr 25 2020, 12:17 PM

Description

Apparently, when viewing talk pages in the mobile version (or the app), potential TemplateStyles will not be applied to the "overlays container", which leads to rather strange outcomes in some cases. Obviously, there will always be templates on talk pages, so TemplateStyles must be applied also in the mobile view (and not just when continuing with "read as wiki page").

Random example: here the table is broken because of missing TemplateStyles

Developer notes

The talk overlay element with classes "content talk-section" needs to also add the class mw-parser-output

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Test#Template_styles on mobile
Verify the box is styled and floated to the right.

QA Results - Beta

AC	Status	Details
1	✅	T251024#6766037

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+3 -3	TemplateStyles applied in mobile talk page (overlay)

Customize query in gerrit

Related Objects

Mentioned In: T212085: TemplateStyles not loaded in NWE preview

Event Timeline

XanonymusX created this task.Apr 25 2020, 12:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2020, 12:17 PM

Hi @XanonymusX, can you please provide a full link to a web address where this issue can be seen? See https://www.mediawiki.org/wiki/How_to_report_a_bug - Thanks.

I have added an example (but it's obviously a general problem, since the overlays container simply does not contain the mw-parser-output class)

Nirmos added a project: MobileFrontend.Apr 25 2020, 3:15 PM

RhinosF1 added a subscriber: RhinosF1.Apr 25 2020, 3:35 PM

ovasileva added a project: Readers-Web-Backlog.Apr 28 2020, 1:59 PM

XanonymusX mentioned this in T212085: TemplateStyles not loaded in NWE preview.May 4 2020, 7:28 PM

• Jdlrobson triaged this task as Medium priority.May 8 2020, 4:21 PM

• Jdlrobson added projects: good first task, patch-welcome.

• Jdlrobson updated the task description. (Show Details)

• Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

ovasileva moved this task from Needs Prioritization to Triaged but Future on the Readers-Web-Backlog board.Jun 9 2020, 4:19 PM

Just as an FYI, another instance I think can be chalked up to this one is here.

• Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 2:38 AM

• Jdlrobson moved this task from Team: web to Team:Editing on the MobileFrontend board.Jul 24 2020, 2:56 AM

• Jdlrobson moved this task from Team:Editing to Team: web on the MobileFrontend board.Jul 24 2020, 3:06 PM

Yash4357 claimed this task.Jan 11 2021, 7:23 PM

Change 655808 had a related patch set uploaded (by Yash9265; owner: Yash9265):
[mediawiki/extensions/MobileFrontend@master] TemplateStyles applied in mobile talk page (overlay)

https://gerrit.wikimedia.org/r/655808

gerritbot added a project: Patch-For-Review.Jan 13 2021, 4:55 AM

• Jdlrobson reassigned this task from Yash4357 to Edtadros.Jan 15 2021, 9:45 PM

• Jdlrobson edited projects, added Readers-Web-Backlog (Kanbanana-FY-2020-21); removed Readers-Web-Backlog.

• Jdlrobson moved this task from Needs Analysis to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

• Jdlrobson added a subscriber: Yash4357.

Hi jdlrobson,
Why did you reassign the task?

Change 655808 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] TemplateStyles applied in mobile talk page (overlay)

https://gerrit.wikimedia.org/r/655808

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2021, 12:10 AM

@Jdlrobson please update with some acceptance criteria or steps. I looked at the link in the description and the Talk:Dog page in Beta and they both look similar.

Wrote QA steps and ended up testing it myself :)

The link to production no longer works, so skipping QA in production as I don't have a good example.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Test#Template_styles on mobile
✅ AC1: Verify the box is styled and floated to the right.

See: T251024#6763561

Screen Recording 2021-01-21 at 8.57.52 AM.mov.gif (756×1 px, 814 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Jan 21 2021, 5:07 PM

Edtadros updated the task description. (Show Details)

Edtadros added a subscriber: Edtadros.

ovasileva closed this task as Resolved.Jan 25 2021, 4:46 PM

	F34011209: Screen Recording 2021-01-21 at 8.57.52 AM.mov.gif
	Jan 21 2021, 5:06 PM

TemplateStyles not applied in mobile talk page (overlay)Closed, ResolvedPublicActions