Page MenuHomePhabricator

TemplateStyles not applied in mobile talk page (overlay)
Closed, ResolvedPublic

Description

Apparently, when viewing talk pages in the mobile version (or the app), potential TemplateStyles will not be applied to the "overlays container", which leads to rather strange outcomes in some cases. Obviously, there will always be templates on talk pages, so TemplateStyles must be applied also in the mobile view (and not just when continuing with "read as wiki page").

Random example: here the table is broken because of missing TemplateStyles

Developer notes

The talk overlay element with classes "content talk-section" needs to also add the class mw-parser-output

QA steps

QA Results - Beta

ACStatusDetails
1T251024#6766037

Event Timeline

Hi @XanonymusX, can you please provide a full link to a web address where this issue can be seen? See https://www.mediawiki.org/wiki/How_to_report_a_bug - Thanks.

I have added an example (but it's obviously a general problem, since the overlays container simply does not contain the mw-parser-output class)

Jdlrobson triaged this task as Medium priority.May 8 2020, 4:21 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

Just as an FYI, another instance I think can be chalked up to this one is here.

Change 655808 had a related patch set uploaded (by Yash9265; owner: Yash9265):
[mediawiki/extensions/MobileFrontend@master] TemplateStyles applied in mobile talk page (overlay)

https://gerrit.wikimedia.org/r/655808

Hi jdlrobson,
Why did you reassign the task?

Change 655808 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] TemplateStyles applied in mobile talk page (overlay)

https://gerrit.wikimedia.org/r/655808

@Jdlrobson please update with some acceptance criteria or steps. I looked at the link in the description and the Talk:Dog page in Beta and they both look similar.

Wrote QA steps and ended up testing it myself :)

The link to production no longer works, so skipping QA in production as I don't have a good example.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Test#Template_styles on mobile
✅ AC1: Verify the box is styled and floated to the right.

See: T251024#6763561

Screen Recording 2021-01-21 at 8.57.52 AM.mov.gif (756×1 px, 814 KB)

Edtadros updated the task description. (Show Details)
Edtadros added a subscriber: Edtadros.