Page MenuHomePhabricator
Create Task
Maniphest T251067

Hard deprecate individual Revision class methods [tracking]
Closed, ResolvedPublic
Actions

Description

Tracking deprecation of all individual public methods of the Revision class.

Static constructors

Other static methods

Public instance methods

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 ResolvedMGCheckerT159299 Deprecate and remove $wgUser
 ResolvedDannyS712T267861 [GOAL] Emit deprecation warnings reading from $wgUser
 ResolvedMGCheckerT243708 Mediawiki core needs uses of global $wgUser removed
 ResolvedDannyS712T246284 Hard deprecate the Revision class
 ResolvedDannyS712T251067 Hard deprecate individual Revision class methods [tracking]
 ResolvedDannyS712T250981 Hard deprecate Revision::getContent(Model|Handler|Format)
 ResolvedDannyS712T250579 Hard deprecate Revision::getUserText
 ResolvedDannyS712T250580 Hard deprecate Revision::isMinor
 ResolvedDannyS712T250608 Hard deprecate Revision::isCurrent
 ResolvedDannyS712T249183 Hard deprecate Revision::newFromTitle
 ResolvedDannyS712T249979 Hard deprecate Revision::newNullRevision
 ResolvedDannyS712T248772 Hard deprecate Revision::newFromArchiveRow
 ResolvedDannyS712T249021 Hard deprecate Revision::newFromId
 ResolvedDannyS712T250980 Hard deprecate Revision::getParentId
 ResolvedDannyS712T250714 Hard deprecate Revision::getVisibility
 ResolvedDannyS712T247259 Remove remaining calls and hard deprecate Revision::userCan
 ResolvedDannyS712T246414 Audit all userCan calls
 ResolvedDannyS712T251073 Hard deprecate Revision::getPrevious
 ResolvedDannyS712T245958 Revision::userCanBitfield falls back to $wgUser
 ResolvedDannyS712T251233 Hard deprecate Revision::getSha1
 ResolvedDannyS712T251593 Hard deprecate Revision::isDeleted
 ResolvedDannyS712T251853 Hard deprecate Revision::getPage
 ResolvedDannyS712T251856 Hard deprecate Revision::insertOn
 ResolvedDannyS712T254703 Hard deprecate Revision::getContent
 ResolvedDannyS712T254960 Hard deprecate Revision::getComment
 ResolvedDannyS712T254964 Hard deprecate Revision::getSize
 ResolvedDannyS712T254966 Hard deprecate Revision::getTimestamp

Event Timeline

DannyS712 created this task.Apr 26 2020, 11:37 PM
DannyS712 triaged this task as Medium priority.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 added subtasks: T250981: Hard deprecate Revision::getContent(Model|Handler|Format), T250579: Hard deprecate Revision::getUserText, T250580: Hard deprecate Revision::isMinor, T250608: Hard deprecate Revision::isCurrent, T249183: Hard deprecate Revision::newFromTitle, T249979: Hard deprecate Revision::newNullRevision, T248772: Hard deprecate Revision::newFromArchiveRow, T249021: Hard deprecate Revision::newFromId, T250980: Hard deprecate Revision::getParentId, T250714: Hard deprecate Revision::getVisibility, T247259: Remove remaining calls and hard deprecate Revision::userCan.Apr 26 2020, 11:39 PM
DannyS712 mentioned this in T246284: Hard deprecate the Revision class.
DannyS712 added a subtask: T251073: Hard deprecate Revision::getPrevious.Apr 27 2020, 4:08 AM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)Apr 27 2020, 4:22 AM
DannyS712 added a subtask: T245958: Revision::userCanBitfield falls back to $wgUser.
DannyS712 updated the task description. (Show Details)Apr 27 2020, 7:06 AM
DannyS712 updated the task description. (Show Details)Apr 27 2020, 5:19 PM
DannyS712 updated the task description. (Show Details)Apr 28 2020, 9:34 AM
daniel edited projects, added Platform Engineering; removed Platform Team Workboards (External Code Reviews).Apr 28 2020, 12:09 PM
daniel moved this task from Inbox to Tracking/Watching on the Platform Engineering board.
daniel subscribed.

There is nothing to review here, all subtasks are tracked separately. Removed from CPT external code review, moved to "tracking" on the CPT board.

DannyS712 closed subtask T251233: Hard deprecate Revision::getSha1 as Resolved.Apr 30 2020, 9:04 PM
DannyS712 updated the task description. (Show Details)Apr 30 2020, 9:07 PM
DannyS712 changed the status of subtask T250980: Hard deprecate Revision::getParentId from Open to Stalled.May 1 2020, 5:27 AM
DannyS712 updated the task description. (Show Details)May 1 2020, 5:55 AM
DannyS712 added a subscriber: • Pchelolo.May 1 2020, 5:58 AM

@daniel can you take a look at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CodeReview/+/585006/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/587313/ ? @Pchelolo gave them +1 but commented saying they were leaving the patch for others to take a look - the patches remove the only deployed uses of Revision::compressRevisionText and Revision::decompressRevisionText

DannyS712 changed the status of subtask T250580: Hard deprecate Revision::isMinor from Open to Stalled.May 1 2020, 6:23 PM
DannyS712 updated the task description. (Show Details)May 5 2020, 3:33 AM
DannyS712 updated the task description. (Show Details)May 5 2020, 3:38 AM
DannyS712 closed subtask T251856: Hard deprecate Revision::insertOn as Resolved.May 22 2020, 9:11 PM
DannyS712 updated the task description. (Show Details)
DannyS712 changed the status of subtask T250580: Hard deprecate Revision::isMinor from Stalled to Open.May 26 2020, 10:13 PM
DannyS712 changed the status of subtask T250980: Hard deprecate Revision::getParentId from Stalled to Open.May 26 2020, 10:59 PM
DannyS712 closed subtask T250579: Hard deprecate Revision::getUserText as Resolved.May 27 2020, 6:35 PM
DannyS712 closed subtask T250608: Hard deprecate Revision::isCurrent as Resolved.
DannyS712 closed subtask T250580: Hard deprecate Revision::isMinor as Resolved.
DannyS712 updated the task description. (Show Details)
DannyS712 closed subtask T250980: Hard deprecate Revision::getParentId as Resolved.May 28 2020, 2:32 AM
DannyS712 closed subtask T250714: Hard deprecate Revision::getVisibility as Resolved.
DannyS712 updated the task description. (Show Details)
DannyS712 closed subtask T251073: Hard deprecate Revision::getPrevious as Resolved.Jun 3 2020, 2:53 AM
DannyS712 closed subtask T251593: Hard deprecate Revision::isDeleted as Resolved.
DannyS712 closed subtask T249021: Hard deprecate Revision::newFromId as Resolved.Jun 3 2020, 3:42 AM
DannyS712 updated the task description. (Show Details)
DannyS712 closed subtask T250981: Hard deprecate Revision::getContent(Model|Handler|Format) as Resolved.Jun 4 2020, 2:13 AM
DannyS712 updated the task description. (Show Details)
DannyS712 closed subtask T254703: Hard deprecate Revision::getContent as Resolved.Jun 8 2020, 5:51 PM
DannyS712 updated the task description. (Show Details)Jun 10 2020, 3:49 AM
DannyS712 closed subtask T254960: Hard deprecate Revision::getComment as Resolved.Jun 10 2020, 5:01 AM
DannyS712 closed subtask T251853: Hard deprecate Revision::getPage as Resolved.
DannyS712 updated the task description. (Show Details)Jun 10 2020, 5:04 AM
DannyS712 closed subtask T254964: Hard deprecate Revision::getSize as Resolved.Jun 10 2020, 5:56 AM
DannyS712 updated the task description. (Show Details)
DannyS712 closed subtask T254966: Hard deprecate Revision::getTimestamp as Resolved.Jun 10 2020, 5:33 PM
DannyS712 updated the task description. (Show Details)
DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Jun 15 2020, 3:13 PM
DannyS712 closed this task as Resolved.Jul 6 2020, 1:59 PM
DannyS712 claimed this task.
DannyS712 updated the task description. (Show Details)
DannyS712 moved this task from In progress to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits