Page MenuHomePhabricator

Add switch to change order in the resolution suggestion
Closed, ResolvedPublic1 Estimated Story Points

Description

No-dragging design solution: Flip button

( taken from T247957#6065384 )

Mock

Switch Button Update.jpg (855×1 px, 547 KB)

Switch Button Update_Specs.jpg (855×1 px, 588 KB)

Uses OOUI markup icon at 16x16 px, rotated 90 deg. This should use the OOUI ButtonWidget (icon only) in the standard size 44 x 32 px . When clicked, it flips the position of the two comments.

The text labels for the entries should be 14px.

Acceptability Criteria

  • Users are able to change the order of the comments by clicking the 'flip' button. This will only be possible for the two conflicting comments and only in in the specific spot the conflict occurred.
  • When the changes are saved or previewed the changes to the order will be respected accordingly
  • On hover over the flip button, users see the tooltop: "Switch order"

See T247957#6069138 and T247957#6070252 for clarification on the fade-out. It should be kept as it is with fading out from the bottom in all cases.

Event Timeline

WMDE-Fisch set the point value for this task to 5.

Change 592873 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Remove draggable code

https://gerrit.wikimedia.org/r/592873

Change 592873 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove draggable code

https://gerrit.wikimedia.org/r/592873

WMDE-Fisch changed the point value for this task from 5 to 3.Apr 29 2020, 8:16 AM

Change 595008 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] [WIP] Add a button that swaps the row order on the talk view

https://gerrit.wikimedia.org/r/595008

Just to get a quick feedback on the current state of this. Assuming the switch button is align between the conflicting comments and the labels for the comments are aligned vertically centered to the height of the comment. Depending on the text in the comments it could look like this:

Screenshot_2020-05-11 Edit conflict Talk Main Page - EnLocalWiki.png (669×1 px, 76 KB)

Screenshot_2020-05-11 Edit conflict Talk Main Page - EnLocalWiki(1).png (669×1 px, 75 KB)

Talk Page-Spacing.jpg (855×1 px, 576 KB)

@WMDE-Fisch Thanks for catching this. I explored a few different spacing options, and after discussing with @Lena_WMDE we settled on the above mock as the least funky/results in the most consistent spacing. The arrow will always be centered on the gap, and the labels will always be spaced based on the arrow placement, instead of changing based on the comment length. This chunk would then move up and down when the comments flip, but the spacing between three elements would remain the same. What do you think?

In T251106#6128774, @ecohen wrote:

Talk Page-Spacing.jpg (855×1 px, 576 KB)

@WMDE-Fisch Thanks for catching this. I explored a few different spacing options, and after discussing with @Lena_WMDE we settled on the above mock as the least funky/results in the most consistent spacing. The arrow will always be centered on the gap, and the labels will always be spaced based on the arrow placement, instead of changing based on the comment length. This chunk would then move up and down when the comments flip, but the spacing between three elements would remain the same. What do you think?

Sounds good and way better than before. I'll change the current patch accordingly.

Change 596095 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Browser tests for swapable talk page blocks

https://gerrit.wikimedia.org/r/596095

Lena_WMDE changed the point value for this task from 3 to 1.May 13 2020, 11:06 AM

Change 595008 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Add a button that swaps the row order on the talk view

https://gerrit.wikimedia.org/r/595008

Change 596095 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Browser tests for swapable talk page blocks

https://gerrit.wikimedia.org/r/596095

Change 596195 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Minimize row swap code in JavaScript a bit

https://gerrit.wikimedia.org/r/596195

Change 596195 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Minimize row swap code in JavaScript a bit

https://gerrit.wikimedia.org/r/596195

To do: We realized the button is a bit hard to understand. Ideas: Add a tooltip. Change the button to have a border. @ecohen will suggest something.

Change 599781 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Frame switch button and increase margins

https://gerrit.wikimedia.org/r/599781

Change 599781 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Frame switch button and increase margins

https://gerrit.wikimedia.org/r/599781

Change 603575 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix broken "Switch order" tooltip

https://gerrit.wikimedia.org/r/603575

Change 603575 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix broken "Switch order" tooltip

https://gerrit.wikimedia.org/r/603575

Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-05-27 board.