Page MenuHomePhabricator

API rollback broken
Closed, ResolvedPublic


Author: alejrb

As far as I can tell, the API rollback is broken on current the deployment version. The API simply returns 'badtoken' to all requests.

No encoding has changed, and this affects JavaScript AJAX rollback scripts, huggle, the anti-vandalism bots which have stopped reverting, and so on.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:00 PM
bzimport set Reference to bz23117.

matthew.britton wrote:

I've patched Huggle to use UI rollback (which still works) so that's OK for now.

Initially I figured it was mis-parsing the token, getting logged out, not sending the cookies properly or one of the other usual causes of 'badtoken' errors, but I also haven't been able to get API rollback working.

An hour or so ago:

<logmsgbot> !log catrope synchronized php-1.5/includes/api/ApiRollback.php 'Live hack for bug 23117'

I applied a live hack on the servers, does that fix it?

philip_trueman wrote:

It works for me - and apparently also for ClueBot. Many thanks.

alejrb wrote:

Yep, that fixed it. Thanks.

And properly fixed on svn head in r64826