Page MenuHomePhabricator

<mapframe>: Javascript exception while rendering a fullscreen map with dialogs
Closed, ResolvedPublic

Description

If a fullscreen map is rendered by Javascript, for instance after clicking on "show in full screen" button at a map, an exception occurs:

jQuery.Deferred exception: dialog.opening is undefined render@https://en.wikivoyage.org/w/load.php?lang=en&modules=ext.kartographer.dialog%7Coojs-ui.styles.icons-interactions&skin=vector&version=1lr6z:2:101

I assume that the exceptions occurs while calling

mw.loader.require( 'ext.kartographer.dialog' ).render( map )

or similar.

For instance, please open https://en.wikivoyage.org/wiki/Aswan and the browser console. Then press "show in full screen" on the map. After this, the exception is shown in the console.

Event Timeline

Change 619556 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/Kartographer@master] Fix exception when opening map

https://gerrit.wikimedia.org/r/619556

Change 619556 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Fix exception when opening map

https://gerrit.wikimedia.org/r/619556

TheDJ removed a project: OOjs core.