Page MenuHomePhabricator

Extract the wbgetentities call for all needed properties(entities) during rendering into another service
Closed, ResolvedPublic

Description

Instead of each service that needs to make a call to wbgetentities making that call, create a service that handles making 1 set of calls and the distributing the results to other fed prop services.

  • So the "magic" prefetching via the label / term lookup would already prefetch the details for the needed entities (this behaviour should be researched and documented later)
  • The service would always fetch all of the information that we need (labels, descriptions and aliases in all possible languages & existence of the entity)
    • calls to wbgetentities would no longer specify a select set of languages, and would not limit the "props" requested so stricly.
  • This service would cache responses in the process
  • This service would allow retrieval of parts of the result
    • for example: getResultPartForId( Q123 )

Event Timeline

Change 594614 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Added an ApiEntityLookup

https://gerrit.wikimedia.org/r/594614

Change 594995 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] FP: Avoid repeatedly fetching the same entities in ApiEntityLookup

https://gerrit.wikimedia.org/r/594995

Change 594614 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: extract wbgetentities api calls into ApiEntityLookup service

https://gerrit.wikimedia.org/r/594614

Change 594995 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Avoid repeatedly fetching the same entities in ApiEntityLookup

https://gerrit.wikimedia.org/r/594995

Samantha_Alipio_WMDE closed this task as Resolved.May 28 2020, 2:26 PM