Page MenuHomePhabricator
Create Task
Maniphest T251238

Use the new wbgetentities service in existing classes
Closed, ResolvedPublic
Actions

Description

This will remove the calls directly to wbgetentities from ApiPrefetchingPropertyTermLookup and ApiPropertyDataTypeLookup, and instead call the service that we just created in T251237.

Details

SubjectRepoBranchLines +/-
Move batching of Entities from ApiPrefetchingTermLookup to ApiEntityLookup.mediawiki/extensions/Wikibasemaster+14 -14
FP: Use the new wbgetentities service (ApiEntityLokup for api fetching entities ) in ApiPrefetchingTermLookup and ApiPropertyDatatypeLookupmediawiki/extensions/Wikibasemaster+65 -90
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Apr 28 2020, 10:12 AM
Addshore mentioned this in T250785: [EPIC] Display statements made with deleted federated properties .Apr 28 2020, 10:21 AM
• Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Apr 30 2020, 10:31 AM
• Samantha_Alipio_WMDE moved this task from Ready to estimate to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.May 4 2020, 9:49 AM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 5/6 (Hike 1)); removed Wikibase - Federated Properties.
Jakob_WMDE renamed this task from Use the new wbgetentities fed prop service in the ApiPrefetchingPropertyTermLookup to Use the new wbgetentities service in existing classes.May 6 2020, 9:33 AM
Jakob_WMDE updated the task description. (Show Details)
Rosalie_WMDE claimed this task.May 11 2020, 8:26 AM
Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.
gerritbot added a comment.May 13 2020, 12:37 AM

Change 596079 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] FP: Use the new wbgetentities service in existing classes

https://gerrit.wikimedia.org/r/596079

gerritbot added a project: Patch-For-Review.May 13 2020, 12:37 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 13 2020, 10:00 AM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 14 2020, 7:31 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 14 2020, 6:57 PM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties; removed Wikibase - Federated Properties (Sprint 5/6 (Hike 1)).May 18 2020, 8:03 AM
• Samantha_Alipio_WMDE moved this task from Sprint 5/6 (Hike 1) to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 6/6 (Hike 1)); removed Wikibase - Federated Properties.May 18 2020, 8:34 AM
• Samantha_Alipio_WMDE moved this task from To do to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.
Addshore moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 18 2020, 9:04 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 18 2020, 1:00 PM
gerritbot added a comment.May 18 2020, 4:02 PM

Change 596079 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Use the new wbgetentities service (ApiEntityLokup for api fetching entities ) in ApiPrefetchingTermLookup and ApiPropertyDatatypeLookup

https://gerrit.wikimedia.org/r/596079

Maintenance_bot removed a project: Patch-For-Review.May 18 2020, 4:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 18 2020, 5:00 PM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 19 2020, 9:02 AM
gerritbot added a comment.May 19 2020, 9:37 AM

Change 597237 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Move batching of Entities from ApiPrefetchingTermLookup to ApiEntityLookup.

https://gerrit.wikimedia.org/r/597237

gerritbot added a project: Patch-For-Review.May 19 2020, 9:38 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 19 2020, 9:39 AM
gerritbot added a comment.May 19 2020, 10:32 AM

Change 597237 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move batching of Entities from ApiPrefetchingTermLookup to ApiEntityLookup.

https://gerrit.wikimedia.org/r/597237

Maintenance_bot removed a project: Patch-For-Review.May 19 2020, 11:11 AM
Rosalie_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 6/6 (Hike 1)) board.May 19 2020, 1:05 PM
• Samantha_Alipio_WMDE closed this task as Resolved.Jun 8 2020, 7:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL