Page MenuHomePhabricator
Create Task
Maniphest T251239

Create a service that is an EntityExistenceChecker
Closed, ResolvedPublic
Actions

Description

This new service should likely have a method like isDeleted( EntityId $entityId )

  • One implementation would use an EntityTitleLookup and the $title->isKnown() method
  • Another implementation would use the new wbgetentities service (implemented in T251237)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+80 -0FP: Add ApiEntityExistenceChecker
mediawiki/extensions/Wikibasemaster+138 -0Add TypeDispatchingExistenceChecker
mediawiki/extensions/Wikibasemaster+90 -0Add EntityExistenceChecker
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Addshore created this task.Apr 28 2020, 10:14 AM
• Addshore mentioned this in T251242: Rewrite LabelsProviderEntityIdHtmlLinkFormatter to remove use of the EntityTitleLookup service.Apr 28 2020, 10:18 AM
• Addshore mentioned this in T250785: [EPIC] Display statements made with deleted federated properties .Apr 28 2020, 10:21 AM
Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Apr 30 2020, 10:31 AM
Samantha_Alipio_WMDE moved this task from Ready to estimate to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.May 4 2020, 9:49 AM
Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 5/6 (Hike 1)); removed Wikibase - Federated Properties.
Samantha_Alipio_WMDE renamed this task from Create a service that is an EntityExistanceChecker to Create a service that is an EntityExistenceChecker.May 4 2020, 10:05 AM
Jakob_WMDE claimed this task.May 4 2020, 1:07 PM
Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.
gerritbot added a comment.May 4 2020, 2:22 PM

Change 594196 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add EntityExistenceChecker

https://gerrit.wikimedia.org/r/594196

gerritbot added a project: Patch-For-Review.May 4 2020, 2:22 PM
gerritbot added a comment.May 4 2020, 3:39 PM

Change 594196 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add EntityExistenceChecker

https://gerrit.wikimedia.org/r/594196

Maintenance_bot removed a project: Patch-For-Review.May 4 2020, 4:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 5 2020, 8:01 AM
gerritbot added a comment.May 5 2020, 9:24 AM

Change 594427 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add TypeDispatchingExistenceChecker

https://gerrit.wikimedia.org/r/594427

gerritbot added a project: Patch-For-Review.May 5 2020, 9:24 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 5 2020, 4:15 PM
gerritbot added a comment.May 6 2020, 12:49 PM

Change 594427 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add TypeDispatchingExistenceChecker

https://gerrit.wikimedia.org/r/594427

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 6 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 6 2020, 1:10 PM
Jakob_WMDE moved this task from Peer Review to To do on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 6 2020, 2:52 PM
Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 13 2020, 7:58 AM
gerritbot added a comment.May 13 2020, 9:17 AM

Change 596159 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] FP: Add ApiEntityExistenceChecker

https://gerrit.wikimedia.org/r/596159

gerritbot added a project: Patch-For-Review.May 13 2020, 9:17 AM
• Addshore moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 13 2020, 12:32 PM
gerritbot added a comment.May 14 2020, 12:48 PM

Change 596159 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Add ApiEntityExistenceChecker

https://gerrit.wikimedia.org/r/596159

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 14 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 14 2020, 1:10 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 14 2020, 1:14 PM
Samantha_Alipio_WMDE closed this task as Resolved.May 28 2020, 2:24 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL