Rewrite LabelsProviderEntityIdHtmlLinkFormatter to remove use of the EntityTitleLookup service
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Apr 28 2020, 10:18 AM

Description

Instead of using an EntityTitleLookup service we should use the services that we have created that are more specific:

EntityExistanceChecker (created in T251239)
EntityUrlLookup (modified for this use in T251241)
EntityTitleTextLookup (T247069 from a previous story)
EntityRedirectChecker (newly created for this task in T252395)

This task not affect federated properties (only wikibase defaults) as we currently override the service for federated properties.
We will alter that in T251243

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove EntityTitleLookup from LabelsProviderEntityIdHtmlLinkFormatter	mediawiki/extensions/Wikibase	master	+276 -221

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T250785 [EPIC] Display statements made with deleted federated properties
Resolved	Jakob_WMDE	T251776 Federated property in a statement should link to source Wiki property page immediately upon saving
Resolved	Silvan_WMDE	T251242 Rewrite LabelsProviderEntityIdHtmlLinkFormatter to remove use of the EntityTitleLookup service

Event Timeline

Addshore created this task.Apr 28 2020, 10:18 AM

Addshore mentioned this in T251243: Rewire the federated properties entity type service definition for the EntityIdLabelFormatter.

Addshore mentioned this in T250785: [EPIC] Display statements made with deleted federated properties .Apr 28 2020, 10:21 AM

• Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Apr 30 2020, 10:31 AM

• Samantha_Alipio_WMDE moved this task from Ready to estimate to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.May 4 2020, 9:49 AM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 5/6 (Hike 1)); removed Wikibase - Federated Properties.

Addshore mentioned this in T251241: Alter EntityUrlLookup interface to allow for context relevant URL.May 4 2020, 10:13 AM

Addshore updated the task description. (Show Details)May 4 2020, 10:17 AM

Addshore mentioned this in T246606: [EPIC] Display statements made with federated properties on item page.May 4 2020, 3:09 PM

Silvan_WMDE claimed this task.May 5 2020, 9:00 AM

Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 5 2020, 9:00 AM

Silvan_WMDE updated the task description. (Show Details)May 6 2020, 2:07 PM

Addshore added a parent task: T251776: Federated property in a statement should link to source Wiki property page immediately upon saving.May 11 2020, 12:19 PM

Silvan_WMDE updated the task description. (Show Details)May 11 2020, 2:59 PM

Change 595547 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] Remove EntityTitleLookup from LabelsProviderEntityIdHtmlLinkFormatter

https://gerrit.wikimedia.org/r/595547

gerritbot added a project: Patch-For-Review.May 11 2020, 3:08 PM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 12 2020, 8:42 AM

Silvan_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 13 2020, 4:09 PM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 14 2020, 10:43 AM

Change 595547 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove EntityTitleLookup from LabelsProviderEntityIdHtmlLinkFormatter

https://gerrit.wikimedia.org/r/595547

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 14 2020, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 14 2020, 12:10 PM

Addshore moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 5/6 (Hike 1)) board.May 14 2020, 12:27 PM

• Samantha_Alipio_WMDE closed this task as Resolved.May 28 2020, 2:24 PM