Page MenuHomePhabricator

change edit pencil link color for dark mode
Closed, ResolvedPublic

Description

(13) When using the Black theme, the color contrast between links and the background is 3.2:1. It should be at least 4.5:1. This was the only color contrast issue observed with the theme settings. Can we use colorAccent (color_group_3) for the links in dark and black mode?

image.png (678×864 px, 185 KB)

The color hex for edit pencils should be #69f#C8CCD1 (See comments from design).

Event Timeline

This comment was removed by bearND.

Change 592771 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] mobile-html: change link color

https://gerrit.wikimedia.org/r/592771

@cmadeo @schoenbaechler I've updated the apps-ui instance with the above patch. Check it out using http://apps-ui.wmflabs.org/en.wikipedia.org/v1/page/mobile-html/Cat?footer=true&theme=dark or similar pages.

The external link icon is still the old color because it's a PNG (not an SVG). Do you agree that this should be changed as well? If so, I've got T251205 for that.

Update: Also what do you think about the text color for the menu item subtext and the read more descriptions? Currently the color for these are overridden using #f8f9fa. Not sure if we need that. I think it looks better with the original color #a2a9b1.

@bearND on the WMFLabs link I'm seeing the link color as #C8CCD1?

@cmadeo Sorry about that. I misunderstood the parent task when it said to change the link color. I thought you meant to change the link color to #C8CCD1 but it was only the edit pencil color that was supposed to be changed. I haven't updated my patch and the apps-ui instance yet.

bearND renamed this task from change link color for dark mode to change edit pencil link color for dark mode.May 5 2020, 3:35 PM

Change 592771 abandoned by BearND:
mobile-html: change link color

Reason:
misunderstanding of the task

https://gerrit.wikimedia.org/r/592771

late to the party but thx for your work on this @bearND 👍

JoeWalsh claimed this task.