Page MenuHomePhabricator

Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35
Closed, ResolvedPublic

Description

A bunch of:

Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35. [Called from UploadBase::checkAgainstArchiveDupes in /srv/mediawiki/php-1.35.0-wmf.28/includes/upload/UploadBase.php at line 876]

logs are seen in production. Probably hard-deprecated a bit too quickly in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/580144

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Pchelolo renamed this task from Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35. [Called from UploadBase::checkAgainstArchiveDupes in /srv/mediawiki/php-1.35.0-wmf.28/includes/upload/UploadBase.php at line 876] to Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35.Apr 28 2020, 11:38 PM

Change 593085 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Pass a user to ArchivedFile::userCan

https://gerrit.wikimedia.org/r/593085

Pchelolo lowered the priority of this task from High to Medium.Apr 29 2020, 1:11 AM

It's not really that high, it's just log noise. No real harm done.

Change 593085 merged by jenkins-bot:
[mediawiki/core@master] Pass a user to ArchivedFile::userCan in UploadBase

https://gerrit.wikimedia.org/r/593085