Page MenuHomePhabricator
Create Task
Maniphest T251386

Special:RecentChanges broken: MutableRevisionRecord: Bad value for parameter $id: must be a integer
Closed, ResolvedPublic
Actions

Description

[4a3541029e14ebf97d9deae5] /wiki/Special:RecentChanges   Wikimedia\Assert\ParameterTypeException from line 105 of /home/developer/mediawiki/workdir/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $id: must be a integer</p><p>Backtrace:</p><p>#0 /home/developer/mediawiki/workdir/includes/Revision/MutableRevisionRecord.php(255): Wikimedia\Assert\Assert::parameterType(array, string, string)<br />
#1 /home/developer/mediawiki/workdir/includes/changes/ChangesList.php(748): MediaWiki\Revision\MutableRevisionRecord-&gt;setId(string)<br />
#2 /home/developer/mediawiki/workdir/includes/changes/ChangesList.php(774): ChangesList-&gt;insertRollback(string, RCCacheEntry)<br />
#3 /home/developer/mediawiki/workdir/includes/changes/EnhancedChangesList.php(702): ChangesList-&gt;getRollback(RCCacheEntry)<br />
#4 /home/developer/mediawiki/workdir/includes/changes/EnhancedChangesList.php(825): EnhancedChangesList-&gt;recentChangesBlockLine(RCCacheEntry)<br />
#5 /home/developer/mediawiki/workdir/includes/changes/EnhancedChangesList.php(118): EnhancedChangesList-&gt;recentChangesBlock()<br />
#6 /home/developer/mediawiki/workdir/includes/specials/SpecialRecentChanges.php(440): EnhancedChangesList-&gt;recentChangesLine(RecentChange, boolean, integer)<br />
#7 /home/developer/mediawiki/workdir/includes/specialpage/ChangesListSpecialPage.php(1661): SpecialRecentChanges-&gt;outputChangesList(Wikimedia\Rdbms\ResultWrapper, FormOptions)<br />
#8 /home/developer/mediawiki/workdir/includes/specialpage/ChangesListSpecialPage.php(671): ChangesListSpecialPage-&gt;webOutput(Wikimedia\Rdbms\ResultWrapper, FormOptions)<br />
#9 /home/developer/mediawiki/workdir/includes/specials/SpecialRecentChanges.php(164): ChangesListSpecialPage-&gt;execute(NULL)<br />
#10 /home/developer/mediawiki/workdir/includes/specialpage/SpecialPage.php(576): SpecialRecentChanges-&gt;execute(NULL)<br />
#11 /home/developer/mediawiki/workdir/includes/specialpage/SpecialPageFactory.php(618): SpecialPage-&gt;run(NULL)<br />
#12 /home/developer/mediawiki/workdir/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory-&gt;executePath(Title, RequestContext)<br />
#13 /home/developer/mediawiki/workdir/includes/MediaWiki.php(973): MediaWiki-&gt;performRequest()<br />
#14 /home/developer/mediawiki/workdir/includes/MediaWiki.php(535): MediaWiki-&gt;main()<br />
#15 /home/developer/mediawiki/workdir/index.php(47): MediaWiki-&gt;run()<br />
#16 {main}

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+4 -4ChangesList::insertRollback - Force rc_this_oldid to integer before use
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Apr 29 2020, 10:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2020, 10:22 AM
Nikerabbit triaged this task as Unbreak Now! priority.Apr 29 2020, 10:27 AM

Also visible on beta cluster: https://meta.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges - a change that happened since last train branch?

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 29 2020, 10:27 AM
Nikerabbit mentioned this in T246284: Hard deprecate the Revision class.Apr 29 2020, 10:32 AM

Confirmed that revert of rMW71b64e46e4b3: ChangesList::insertRollback - remove internal use of Revision objects makes this error go away.

Nikerabbit added a parent task: T249963: 1.35.0-wmf.31 deployment blockers.Apr 29 2020, 10:36 AM
DannyS712 added a subscriber: DannyS712.Apr 29 2020, 10:50 AM

Is T251364: Beta cluster: changes list special pages return Internal error: TypeError: Cannot read property 'limitDefault' of null the same thing?

DannyS712 claimed this task.Apr 29 2020, 10:51 AM

@Nikerabbit does it say what the value is, if not an integer?

Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 29 2020, 10:51 AM
Nikerabbit added a comment.Apr 29 2020, 10:52 AM

Looks the same, the JavaScript error is likely just a by-product of the page failing to load.

gerritbot added a comment.Apr 29 2020, 10:55 AM

Change 593212 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ChangesList::insertRollback - Force rc_this_oldid to integer before use

https://gerrit.wikimedia.org/r/593212

gerritbot added a project: Patch-For-Review.Apr 29 2020, 10:55 AM
DannyS712 added a comment.Apr 29 2020, 11:11 AM
In T251386#6092884, @Nikerabbit wrote:

Confirmed that revert of rMW71b64e46e4b3: ChangesList::insertRollback - remove internal use of Revision objects makes this error go away.

Yeah, that was the cause :( - I missed that the stdClass values were strings and RevisionStore::initializeMutableRevisionFromArray converted the id to int

DannyS712 added a comment.Apr 29 2020, 11:13 AM
In T251386#6092967, @gerritbot wrote:

Change 593212 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ChangesList::insertRollback - Force rc_this_oldid to integer before use

https://gerrit.wikimedia.org/r/593212

Confirmed to solve the issue via PatchDemo - http://patchdemo.wmflabs.org/wikis/ef762db15970a840193e89092524de8e/w/index.php/Special:RecentChanges?hidebots=1&limit=50&days=7&enhanced=1&urlversion=2

Aklapper added a project: MediaWiki-Recent-changes.Apr 29 2020, 11:25 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 29 2020, 11:25 AM
Aklapper added a parent task: T249962: 1.35.0-wmf.30 deployment blockers.Apr 29 2020, 11:25 AM
DannyS712 added a comment.Apr 29 2020, 11:29 AM

@Aklapper this isn't an issue in wmf.30, patch was merged after branch cut - https://test.wikipedia.org/wiki/Special:RecentChanges works fine

DannyS712 removed a parent task: T249962: 1.35.0-wmf.30 deployment blockers.Apr 29 2020, 11:29 AM
DannyS712 added a comment.Apr 29 2020, 11:45 AM
In T251386#6093061, @DannyS712 wrote:
In T251386#6092967, @gerritbot wrote:

Change 593212 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ChangesList::insertRollback - Force rc_this_oldid to integer before use

https://gerrit.wikimedia.org/r/593212

Confirmed to solve the issue via PatchDemo - http://patchdemo.wmflabs.org/wikis/ef762db15970a840193e89092524de8e/w/index.php/Special:RecentChanges?hidebots=1&limit=50&days=7&enhanced=1&urlversion=2

When testing to confirm, please note that T251404: `editingold` when creating a new page is a separate issue with a separate fix submitted, and so that issue may appear in testing (side note: 2 unbreak now tasks for two different trains? wow, not what I was expected to be doing right now)

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Apr 29 2020, 11:49 AM
DannyS712 merged a task: T251364: Beta cluster: changes list special pages return Internal error: TypeError: Cannot read property 'limitDefault' of null.Apr 29 2020, 11:55 AM
gerritbot added a comment.Apr 29 2020, 2:03 PM

Change 593212 merged by jenkins-bot:
[mediawiki/core@master] ChangesList::insertRollback - Force rc_this_oldid to integer before use

https://gerrit.wikimedia.org/r/593212

DannyS712 closed this task as Resolved.Apr 29 2020, 2:03 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 added a comment.Apr 29 2020, 2:24 PM

Confirmed to work on the beta cluster

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 3:00 PM
DannyS712 mentioned this in T251950: MutableRevisionRecord: Bad value for parameter $visibility: must be a integer.May 5 2020, 9:15 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM
DannyS712 mentioned this in T255088: Internal error on Special:RecentChanges: "NamespaceInfo::isTalk called with non-integer (string) namespace '-1'".Jun 11 2020, 1:19 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL