Page MenuHomePhabricator

`editingold` when creating a new page
Closed, ResolvedPublicBUG REPORT

Description

editingold - Warning: You are editing an out-of-date revision of this page. If you save it, any changes made since this revision will be lost.

Steps to reproduce:
Try to create a page that doesn't exist yet on testwiki (or another wiki on wmf.30)

Expected result:
Since the page doesn't exist, no editingold warning is shown

Actual result:
Warning is shown

Does not occur when creating a new section or editing an existing page
Relevant logic in EditPage::showHeader

I caused this in https://gerrit.wikimedia.org/r/#/q/Ib8f399e451c3a9b942001b48ea9a138f405c894c as part of T246284: Hard deprecate the Revision class

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 29 2020, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Unbreak Now! priority.Apr 29 2020, 11:28 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 changed the subtype of this task from "Production Error" to "Bug Report".

As a train blocker

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 29 2020, 11:28 AM

Change 593214 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593214

Change 593214 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593214

Confirmed to work (tested locally)

DannyS712 updated the task description. (Show Details)

I confirm that I can reproduce this in the non-visual editor.

It seems like a non-functional issue, though. The edit works OK, but the user sees a confusing warning message. As such, I don't think this blocks promotion to group1. We should find someone who can CR+2 this confidently, get it merged into master, and than backport the fix to wmf.30, possibly during SWAT.

I fear I don't understand the code base enough to review the code myself.

Ankry added a subscriber: Ankry.Apr 29 2020, 2:13 PM
Masti added a subscriber: Masti.Apr 29 2020, 3:14 PM

Change 593214 merged by jenkins-bot:
[mediawiki/core@master] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593214

Change 593260 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.30] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593260

Change 593260 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.30] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593260

Backport scheduled for swat: Wednesday, April 29 18:00–19:00 UTC morning swat

Change 593260 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.30] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593260

Mentioned in SAL (#wikimedia-operations) [2020-04-29T16:53:46Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.30/includes/EditPage.php: EditPage::showHeader - only warn editing an old revision if it exists T251404 (duration: 01m 06s)

Jdforrester-WMF closed this task as Resolved.Apr 29 2020, 4:56 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Backported and confirmed fixed.