`editingold` when creating a new page
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DannyS712
	Apr 29 2020, 11:27 AM

Description

editingold - Warning: You are editing an out-of-date revision of this page. If you save it, any changes made since this revision will be lost.

Steps to reproduce:
Try to create a page that doesn't exist yet on testwiki (or another wiki on wmf.30)

Expected result:
Since the page doesn't exist, no editingold warning is shown

Actual result:
Warning is shown

Does not occur when creating a new section or editing an existing page
Relevant logic in EditPage::showHeader

I caused this in https://gerrit.wikimedia.org/r/#/q/Ib8f399e451c3a9b942001b48ea9a138f405c894c as part of T246284: Hard deprecate the Revision class

Details

Request URL: https://test.wikipedia.org/w/index.php?title=Main_Page123412341&action=edit

	Subject	Repo	Branch	Lines +/-
	EditPage::showHeader - only warn editing an old revision if it exists	mediawiki/core	wmf/1.35.0-wmf.30	+2 -1
	EditPage::showHeader - only warn editing an old revision if it exists	mediawiki/core	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T251386: Special:RecentChanges broken: MutableRevisionRecord: Bad value for parameter $id: must be a integer
T249962: 1.35.0-wmf.30 deployment blockers
Mentioned Here: T246284: Hard deprecate the Revision class

Event Timeline

DannyS712 created this task.Apr 29 2020, 11:27 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 29 2020, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

As a train blocker

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 29 2020, 11:28 AM

Change 593214 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593214

gerritbot added a project: Patch-For-Review.Apr 29 2020, 11:40 AM

In T251404#6093140, @gerritbot wrote:

Change 593214 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593214

Confirmed to work (tested locally)

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Apr 29 2020, 11:41 AM

DannyS712 mentioned this in T249962: 1.35.0-wmf.30 deployment blockers.

DannyS712 mentioned this in T251386: Special:RecentChanges broken: MutableRevisionRecord: Bad value for parameter $id: must be a integer.Apr 29 2020, 11:45 AM

DannyS712 added a project: Platform Engineering.Apr 29 2020, 11:49 AM

DannyS712 updated the task description. (Show Details)

I confirm that I can reproduce this in the non-visual editor.

It seems like a non-functional issue, though. The edit works OK, but the user sees a confusing warning message. As such, I don't think this blocks promotion to group1. We should find someone who can CR+2 this confidently, get it merged into master, and than backport the fix to wmf.30, possibly during SWAT.

I fear I don't understand the code base enough to review the code myself.

• LarsWirzenius removed a parent task: T249962: 1.35.0-wmf.30 deployment blockers.Apr 29 2020, 12:49 PM

Ankry subscribed.Apr 29 2020, 2:13 PM

Masti subscribed.Apr 29 2020, 3:14 PM

Change 593214 merged by jenkins-bot:
[mediawiki/core@master] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593214

Change 593260 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.30] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593260

In T251404#6093999, @gerritbot wrote:

Change 593260 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.30] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593260

Backport scheduled for swat: Wednesday, April 29 18:00–19:00 UTC morning swat

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 4:00 PM

Change 593260 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.30] EditPage::showHeader - only warn editing an old revision if it exists

https://gerrit.wikimedia.org/r/593260

Reedy merged a task: T251429: Creating a new page shows "You are editing a prior version of this page....".Apr 29 2020, 4:45 PM

Reedy added a subscriber: Raymond.

Ciencia_Al_Poder merged a task: T251429: Creating a new page shows "You are editing a prior version of this page....".Apr 29 2020, 4:45 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-29T16:53:46Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.30/includes/EditPage.php: EditPage::showHeader - only warn editing an old revision if it exists T251404 (duration: 01m 06s)

Backported and confirmed fixed.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2020, 5:10 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM

`editingold` when creating a new pageClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

`editingold` when creating a new page
Closed, ResolvedPublicBUG REPORT
Actions