Page MenuHomePhabricator

Include snippet in action=query&generator=search results
Closed, InvalidPublic

Description

action=query&list=search requests include props like snippet in the results.
None of that information is present when used as generator, though.
It'd be very convenient to have the snippet available in generator as well - it otherwise half defeats the point of having a generator, when we can't use it as such (if you want the search-specific props)

Event Timeline

Change 592407 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] Include search results data in generator output

https://gerrit.wikimedia.org/r/592407

@matthiasmullie @mwilliams If I remember correctly, we created this task in order to show more information in the search results in Media Search. Now that that's no longer part of the design (with the introduction of QuickView), can we close this task?

I don't totally understand this ticket but I based the current design around not being able to retrieve any sort of consistent description or caption for a majority of the files in a performant way, so yes this might be outdated but defer to @matthiasmullie

Change 592407 abandoned by Matthias Mullie:
[mediawiki/core@master] Include search results data in generator output

Reason:
We're not pursuing this

https://gerrit.wikimedia.org/r/592407

This ticket was about making the search API include additional relevant search information in the API results that we cannot currently get - the most important one being the snippet of text that matched the search result.
We were going to look into not using that snippet because 1/ the text is often very bad, 2/ when images are found based on structured data, the snippet is mostly irrelevant anyway, and 3/ the data is not currently available anyway...
Happy to hear we're not going to need it and ruled it out completely (doublechecking: even for non-media results?) - closing the ticket.