Page MenuHomePhabricator
Create Task
Maniphest T251422

Write / update unit tests for SiteConfig.php after completing refactoring of SiteConfig class hierarchy
Closed, ResolvedPublic
Actions

Description

It is easier now to keep config code better tested with the refactoring in T231568.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to v0.13.0-a4mediawiki/vendorwmf/1.36.0-wmf.3+2 K -5 K
Bump wikimedia/parsoid to v0.13.0-a4mediawiki/vendormaster+2 K -5 K
Add more SiteConfig unit testsmediawiki/services/parsoidmaster+198 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry created this task.Apr 29 2020, 3:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2020, 3:26 PM
ssastry triaged this task as Medium priority.Apr 29 2020, 3:26 PM
ssastry added a subtask: T231568: Push more functionality out of SiteConfig subclasses into the root SiteConfig class.
ssastry moved this task from Needs Triage to Testing on the Parsoid board.
ssastry moved this task from Incoming Work (but not yet ready) to Todo (Roadmap Critical Path) on the Parsing-Active-Work board.
gerritbot added a comment.Apr 30 2020, 6:04 PM

Change 593576 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Add more SiteConfig unit tests

https://gerrit.wikimedia.org/r/593576

gerritbot added a project: Patch-For-Review.Apr 30 2020, 6:04 PM
ssastry claimed this task.May 1 2020, 10:14 PM
ssastry closed subtask T231568: Push more functionality out of SiteConfig subclasses into the root SiteConfig class as Resolved.
ssastry moved this task from Todo (Roadmap Critical Path) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.
ssastry moved this task from Doing (Roadmap Critical Path) to Doing (Other Work) on the Parsing-Active-Work board.Jun 8 2020, 3:13 PM
ssastry moved this task from Testing to Current & Upcoming Work on the Parsoid board.Jul 2 2020, 6:39 PM
gerritbot added a comment.Jul 29 2020, 9:33 PM

Change 593576 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add more SiteConfig unit tests

https://gerrit.wikimedia.org/r/593576

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 10:10 PM
gerritbot added a comment.Aug 4 2020, 2:17 AM

Change 618166 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a4

https://gerrit.wikimedia.org/r/618166

gerritbot added a project: Patch-For-Review.Aug 4 2020, 2:17 AM
gerritbot added a comment.Aug 4 2020, 3:18 AM

Change 618038 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@wmf/1.36.0-wmf.3] Bump wikimedia/parsoid to v0.13.0-a4

https://gerrit.wikimedia.org/r/618038

gerritbot added a comment.Aug 4 2020, 3:33 AM

Change 618166 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a4

https://gerrit.wikimedia.org/r/618166

gerritbot added a comment.Aug 4 2020, 4:11 AM

Change 618038 merged by jenkins-bot:
[mediawiki/vendor@wmf/1.36.0-wmf.3] Bump wikimedia/parsoid to v0.13.0-a4

https://gerrit.wikimedia.org/r/618038

ssastry closed this task as Resolved.Aug 5 2020, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits