Page MenuHomePhabricator

Add filters specific to the timeline tab
Open, LowPublic

Description

The timeline tab results can be filtered by the same criteria as the Compare tab + Pages, Browser, and Activity.

Acceptance criteria:

  • A user should be able to exclude multiple pages from the results
  • A user should be able to exclude multiple Activities from the results
  • A user should be able to exclude multiple Browsers from the results

Event Timeline

dmaza created this task.Apr 29 2020, 8:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2020, 8:17 PM
Niharika added a subscriber: Niharika.

This task is waiting on the feedback we receive from users in our next round of user testing.

Should we remove the filter field from the timeline tab in the meantime? It might look misleading during testing since it does nothing. (It's a trivial amount of work to remove it.)

@Aklapper What's up with the tag changes?

@Niharika: I removed an initial subscriber which should not have been a subscriber but looked like it should be a project tag, but looks like it should not have been a project tag either. Thanks for the correction. :)

In {T248588#6131426} we found that the Timeline query is quite slow but possibly acceptable as it is. However, we also saw that filters slow queries down.

Of the filters mentioned in the task description, the target filter seems the most important since it's already available in the Compare tab, and allows the Timeline results to be consistent with that.

However, I think if we want to add the other filters then we may need to rethink how we're getting the data, as mentioned in T249374#6132930.

Related to this, I've made a separate task for adding the filters that already exist in the Compare tab to the Timeline tab: T253327. (The Timeline results are currently never filtered.)

@Niharika Am I right in thinking that we still want those filters?

Niharika added a comment.EditedMay 21 2020, 11:02 PM

Related to this, I've made a separate task for adding the filters that already exist in the Compare tab to the Timeline tab: T253327. (The Timeline results are currently never filtered.)

@Niharika Am I right in thinking that we still want those filters?

@Tchanders It makes sense to have them but the want they are currently designed in the UI (under the tabs rather than above them), it makes it seem like they are per-tab and it's not intuitive that they would reflect in the other tabs when the user switches between them. It might need a little more design thinking before we work on that task. I'll ask Prateek to take a look into it.
Thanks for creating the task!

@Niharika Good point, was meaning to run that by you - feel free to update the description for T253327.

Niharika triaged this task as Low priority.Jun 2 2020, 4:35 PM