Page MenuHomePhabricator

Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate
Closed, ResolvedPublicJun 2 2020

Description

SpecialCheckUser triggers a hook (SpecialCheckUserGetLinksFromRow) here on every row being displayed when querying for user/ip edits. This hook allows extensions to modify links such as rev diff|hist|etc with whatever they need and it is currently only used by Flow here

The problem we face is that one of the hook's arguments is the SpecialPage instance and with our new implementation these links are not being created in a special page so backward compatibility is not an option.

This task is to find a way to provide the same functionality with a hook and fix or implement the same behavior for SpecialInvestigate/Timeline

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptApr 29 2020, 8:40 PM
Niharika triaged this task as Medium priority.May 13 2020, 3:59 PM

Change 596056 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Replace the SpecialCheckUserGetLinksFromRow hook with CheckUserGetLinksFromRow

https://gerrit.wikimedia.org/r/596056

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 598845 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Deprecate SpecialCheckUserGetLinksFromRow

https://gerrit.wikimedia.org/r/598845

Change 599043 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Add CheckUserFormatRow hook for TimelinePager::formatRow

https://gerrit.wikimedia.org/r/599043

Change 599043 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add CheckUserFormatRow hook for TimelinePager::formatRow

https://gerrit.wikimedia.org/r/599043

Change 596056 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Replace the SpecialCheckUserGetLinksFromRow hook with CheckUserGetLinksFromRow

https://gerrit.wikimedia.org/r/596056

Change 598845 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Deprecate SpecialCheckUserGetLinksFromRow

https://gerrit.wikimedia.org/r/598845

@dbarratt do these two need to be merged as well?

Change 596056 abandoned by Dbarratt:
Replace the SpecialCheckUserGetLinksFromRow hook with CheckUserGetLinksFromRow

https://gerrit.wikimedia.org/r/596056

Change 598845 abandoned by Dbarratt:
Deprecate SpecialCheckUserGetLinksFromRow

https://gerrit.wikimedia.org/r/598845

I retested the links on the Timeline tab. They work as they did before.