Page MenuHomePhabricator

History page insert `ins`/ delete `del` elements have accessibility issues
Closed, DuplicatePublic

Description

Looking for example at https://en.m.wikipedia.org/wiki/Special:MobileDiff/911796127?diffmode=source current history diff view in non-AMC mode:

image.png (938×1 px, 140 KB)

Inserted and deleted text currently features a non-Style-Guide-conform color scheme, but even more so, doesn't conform to contrast ratio requirements. Additionally, they are relying only on color (overriding browser defaults) which is another breakage of accessibility guidelines.

Background:

  • In core/Vector it became a yellow/blue combination to cover red/green blindness

image.png (350×2 px, 57 KB)

  • Browser default styling for ins/del elements is overwritten in MF, it adds underline and strike-through text decoration.

Proposal

To not overcomplicate things as the long-term goal is to provide core diffing, it makes sense to show default text treatment on top of Green90/Red90 background colors.

image.png (754×818 px, 103 KB)

Event Timeline

Change 593366 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Special:MobileDiff: Use standard colors and use additional visual indicators

https://gerrit.wikimedia.org/r/593366

ovasileva triaged this task as Medium priority.Jan 5 2021, 9:41 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Change 593366 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Special:MobileDiff: Use standard colors and use additional visual indicators

Reason:

Clearing out the review queue for 2022. Please restore whenever you can pick up this work again.

https://gerrit.wikimedia.org/r/593366