Page MenuHomePhabricator

Use SearchMappings in MW Core
Open, LowPublic

Description

T250977: Decouple $wgSearchType/$wgSearchTypeAlternatives from PHP class added mapping functionality to allow extensions to decouple $wgSearchType/$wgSearchTypeAlternatives from the underlying PHP class using ObjectFactory specification

However, it didn't give mappings for classes in MW core that are subclasses of SearchDatabase etc in core

Obviously this isn't a problem atm, but at some point SearchMySQL will be namespaced too, and we don't want to keep aliases around for ever, and similar to T250812: Deal with dropping of Global CirrusSearch class, we don't want to have to have $wgSearchType/$wgSearchTypeAlternatives set to 'MediaWiki\Search\MySQL' etc (it's not exactly great in the current state in the API either - where you can end up being able to pass srbackend=SearchMySQL), so having mappings for something like 'mysql' => 'SearchMySQL' in the mix would make sense, and then being able to set $wgSearchType/$wgSearchTypeAlternatives to 'mysql' (and 'SearchMySQL' for back compat for some time?)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy triaged this task as Low priority.Apr 30 2020, 2:23 PM
MPhamWMF added a subscriber: MPhamWMF.

Closing out low/est priority tasks over 6 months old with no activity within last 6 months in order to clean out the backlog of tickets we will not be addressing in the near term. Please feel free to reopen if you think a ticket is important, but bare in mind that given current priorities and resourcing, it is unlikely for the Search team to pick up these tasks for the indefinite future. We hope that the requested changes have either been addressed by or made irrelevant by work the team has done or is doing -- e.g. upgrading Elasticsearch to a newer version will solve various ES-related problems -- or will be subsumed by future work in a more generalized way.