Page MenuHomePhabricator

Omit history navigation links when no results are found
Closed, ResolvedPublic

Description

When filtering page history by a date, there may be no matching revisions that can be shown. Following T227578, a placeholder is set, but this is what you see:

Immagine.jpg (431×1 px, 78 KB)

Instructions for solving: in includes/actions/pagers/HistoryPager.php, override method isNavigationBarShown and return false if getNumRows returns 0, otherwise return what the parent method would.

Event Timeline

matej_suchanek updated the task description. (Show Details)
Zabe added a subscriber: Zabe.

I would like to try to tackle this

Change 667630 had a related patch set uploaded (by Zabe; owner: Zabe):
[mediawiki/core@master] Omit history navigation links when no results are found

https://gerrit.wikimedia.org/r/667630

Change 667630 merged by jenkins-bot:
[mediawiki/core@master] Omit history navigation links when no results are found

https://gerrit.wikimedia.org/r/667630