Page MenuHomePhabricator

[Epic] Enable DiscussionTools on pages not in a talk namespace
Closed, ResolvedPublic

Description

This tasks represents the work involved with making sure DiscussionTools tools appear on pages editors expect.

Specifically, this task is about making sure new talk pages features appear on all pages where discussions are happening, regardless of the namespaces in which they exist.

It is important to note that a component of the above is making sure DiscussionTools tools do not appear on talk pages where discussions do not/should not happen.

Related Objects

StatusSubtypeAssignedTask
ResolvedEsanders
ResolvedEsanders
ResolvedEsanders
Resolvedppelberg
ResolvedEsanders
Resolved• Whatamidoing-WMF
Resolvedppelberg
Resolved• matmarex
Resolvedppelberg
ResolvedNone
Resolvedppelberg
OpenNone
Resolvedppelberg
Resolved• matmarex
Resolved• matmarex
ResolvedEsanders

Event Timeline

I'm removing this epic as blocking T282639 because in T304751 we decided to initially limit Topic Containers to being available in the User and Article talk namespaces. As such, this ticket is not relevant to the Beta Feature deployment.

Esanders claimed this task.
Esanders subscribed.

The current logic means enhancements are available on most talk pages, and can be added to more with __NEWSECTIONLINK__ (excluding the main namespace):

// Visual enhancements are only enabled on talk namespaces (T325417) ...
return $title->isTalkPage() || (
	// ... or __NEWSECTIONLINK__ (T331635) or __ARCHIVEDTALK__ (T374198) pages
	(
		static::hasPagePropCached( $title, 'newsectionlink' ) ||
		static::hasPagePropCached( $title, 'archivedtalk' )
	) &&
	// excluding the main namespace, unless it has been configured for signatures
	(
		!$title->inNamespace( NS_MAIN ) ||
		$services->getNamespaceInfo()->wantSignatures( $title->getNamespace() )
	)
);