Page MenuHomePhabricator
Create Task
Maniphest T251679

autofocus bug with MW Page Forms popups
Closed, DeclinedPublicBUG REPORT
Actions

Description

Environment:

  1. Metrolook 7.0 alpha 2 (48c1b49)
  2. MediaWiki 1.34.1 (3bdc458)
  3. Page Forms Page Forms 4.8
  4. ref: https://emw-meza.site/fbtest/Special:Version

Issue Description:
Metrolook CSS causes problematic autofocus issue when using Page Forms #formlink popup feature. I have set-up a live example of this problematic behavior at:

https://emw-meza.site/fbtest/Metrolook_PF_Popup_Issue

Steps to Reproduce:

  1. visit: https://emw-meza.site/fbtest/Metrolook_PF_Popup_Issue
  2. click the formlink
  3. scroll to the bottom of the form
  4. click the textarea form field
  5. observe that Metrolook CSS automatically moves the focus to the top of the page
  6. scroll down again repeat 3-5 as often as you'd like

Expected Results:
It is expected that clicking the form fields would keep the focus on where the cursor is.

Related Objects

Event Timeline

Revansx created this task.May 2 2020, 1:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2020, 1:53 PM
Revansx updated the task description. (Show Details)May 2 2020, 1:54 PM
Revansx added a comment.May 2 2020, 3:52 PM

Even if it is the determination of the Metrolook developers that this is a Page Forms issue, I would be grateful for any simple ways to halt this behavior, even if it is kinda hackish. Thanks!

Revansx added a comment.EditedMay 2 2020, 4:07 PM

I believe I have isolated the behavior to the following JS code in Metrolook:

mediawiki/skins/Metrolook/js/fixed-header-scroll-fix.js

It would appear that this "fixed header scroll" is not handling the popup iframe of Page Forms.

Revansx reassigned this task from Paladox to Immewnity.May 5 2020, 6:20 PM
Revansx added a subscriber: Paladox.
Aklapper added a comment.May 5 2020, 8:47 PM

@Revansx: Hi, could you explain what's the reason for (re)assigning the task? Did Paladox and/or Immewnity explicitly agree to work on this?

Revansx added a comment.EditedMay 6 2020, 12:12 AM

I just thought that is was appropriate to assign them. My apologies if that was bad protocol. I thought it was the right thing to do. Was it?

Immewnity removed Immewnity as the assignee of this task.May 6 2020, 3:03 AM
Immewnity subscribed.

The listed script is one that I didn't have in the initial version of the skin (the one in use on PidgiWiki), and I have not followed the changes Paladox has made. Apologies.

Revansx added a comment.May 6 2020, 3:18 AM

I understand. Do you have any thoughts on how I might debug it? Any idea what could cause a page to scroll to the top no matter where you click it? Any insights or things to try would be greatly appreciated. I'd hate to have to disable Metrolook due to something so (presumably) simple for someone versed in responsive design.

Aklapper added a comment.May 6 2020, 10:34 AM
In T251679#6111171, @Revansx wrote:

I just thought that is was appropriate to assign them. My apologies if that was bad protocol. I thought it was the right thing to do. Was it?

@Revansx: Ah, thanks! Please avoid. :) See https://www.mediawiki.org/wiki/How_to_report_a_bug

Revansx added a comment.EditedMay 7 2020, 3:35 PM

Is there anyone who is willing give me some advice on how to debug/resolve this myself?

Revansx added a comment.Aug 5 2020, 11:19 PM

Is there anyone who is willing give me some advice on how to debug/resolve this myself?

Aklapper added a comment.Aug 6 2020, 6:36 AM

@Revansx: I'd start with fixing the fatal exception on that website (which might or might not be related).
See the console of your browser's developer tools and https://www.mediawiki.org/wiki/Manual:How_to_debug

Aklapper added a comment.Aug 29 2020, 7:31 PM

@Revansx: Is this still a problem? Asking as https://emw-meza.site/fbtest/Metrolook_PF_Popup_Issue says "You do not have permission to edit this page, for the following reason: The action you have requested is limited to users in the group: Users." and as https://emw-meza.site/fbtest/index.php?title=Special:CreateAccount fails with "The supplied credentials could not be used for account creation." after not asking me for a password at all before. Hence cannot test anything.

Aklapper closed this task as Declined.Sep 23 2020, 7:48 AM

Unfortunately closing this Phabricator task as no further information has been provided.

@Revansx: After you have provided the information asked for and if this still happens, please set the status of this task back to "Open" via the Add Action... → Change Status dropdown. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL