@Samantha_Alipio_WMDE Should this be changing the behaviour for local properties as well?

Currently the standard behaviour is the following:

Changing it for all entities in Wikibase in general will be less work than trying to only do this for the federated properties case.

@Addshore Yes to changing the behavior for local properties. Aside from being less work, I see a benefit in third-party Wikibases in having the P number for any deleted property linked to its remnant page. In Wikidata, the property deletion process is fairly structured and includes time for debate and time for migrating values over to a replacement property. A third-party Wikibase may not follow that same process, so making it easier to access the recent logs for a deleted property that was used in a statement would likewise make it easier to uncover if a property deletion was done in error.

Sorry, when I say local properties, I meant to imply that we would thus also be changing this behaviour for wikidata.org.
Thus Lydia probably needs a ping.

Got it! Ping @Lydia_Pintscher -- do you see an issue with what we're doing here, as it will impact how deleted properties used in statements are displayed on Wikidata? My take is since users on WD are taking care of migrating values for deleted properties before the deletion happens, this change shouldn't be visible to them.

I understand that what we're changing is just linking the Property ID. That should be fine for Wikidata as well, yeah. Since it is a link to a deleted page it should probably be a red link as for other links to non-existent pages?

NonExistingEntityIdHtmlFormatter is the class that does the formatting in this deleted case as far as we can see.
This is used in ItemPropertyIdHtmlLinkFormatter which ends up going through a chain of things and into EntityView down the snak templating.

While looking through the code we noticed that the "easy" way would also turn deleted items into links.

Is this desired?

We figured out an easy way to avoid needing to answer that question!

• Create a NonExistingEntityIdHtmlFormatter that creates red links to entities when formatting them
• Alter the formatter-factory-callback for WikibaseRepo.datatypes.php PT:wikibase-property to use the new linking formatted
  • Keeping the PY:wikibase-item formatter the same (not linking)

Tasks to follow