Page MenuHomePhabricator

Deprecate unused (non-actual) methods of WikiPage and Article (with subclasses)
Open, Needs TriagePublic

Description

Context:

I found many unused methods, while I was working with https://phabricator.wikimedia.org/T239975

I recommend:

  • to research the usage of these methods
  • to hard deprecate these methods
  • to remove them in 1.36

Goal:

  • to improve WikiPage/Article
  • to minimize public methods and codebase of these classes

Methods for deprecation:

  • \CachedAction\CachedAction\CachedAction\CachedAction

https://codesearch.wmflabs.org/deployed/?q=CachedAction&i=nope&files=%5C.php%24&repos=

  • \WikiPage::pageDataFromId

https://codesearch.wmflabs.org/deployed/?q=pageDataFromId&i=nope&files=%5C.php%24&repos=

  • \WikiPage::getCreator

https://codesearch.wmflabs.org/deployed/?q=getCreator%5C(&i=nope&files=%5C.php%24&repos=

  • \WikiPage::getMinorEdit

https://codesearch.wmflabs.org/deployed/?q=getMinorEdit%5C(&i=nope&files=%5C.php%24&repos=

  • \WikiPage::supportsSections

https://codesearch.wmflabs.org/deployed/?q=supportsSections%5C(&i=nope&files=%5C.php%24&repos=

  • \ImagePage::getDuplicates

https://codesearch.wmflabs.org/deployed/?q=getDuplicates&i=nope&files=%5C.php%24&repos=

  • \ImagePage::getForeignCategories

https://codesearch.wmflabs.org/deployed/?q=getForeignCategories&i=nope&files=%5C.php%24&repos=

  • \InfoAction::getContributors

https://codesearch.wmflabs.org/deployed/?q=getContributors&i=nope&files=%5C.php%24&repos=

  • \ImagePage::isLocal - No usages, but research needed

Property for deprecation:

  • \WikiPage::$mPreparedEdit - Usage looks like not actual