Page MenuHomePhabricator

Vagrant should use $wgLogos instead of deprecated $wgLogo
Closed, ResolvedPublic

Event Timeline

Tgr created this task.May 5 2020, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2020, 1:22 PM
Restricted Application added a project: User-Zoranzoki21. · View Herald TranscriptMay 5 2020, 1:29 PM

Only in one file. There is two more, but I will update it.

kizule@DESKTOP-M9SBSVQ:~/development/vagrant$ git grep wgLogo
LocalSettings.php:$wgLogos = [
puppet/modules/mediawiki/templates/multiwiki/LoadWgConf.php.erb:        'wgLogo' => array(
puppet/modules/role/manifests/labs_initial_content.pp:            wgLogo          => '/labs_mediawiki_logo.png',
kizule@DESKTOP-M9SBSVQ:~/development/vagrant$
Tgr added a comment.May 5 2020, 1:40 PM

Yeah, sorry for the vague task, this is about the files generated in settings.d. (settings.d/wikis/<wiki>/LocalSettings.php also has wgLogo but maybe that's created by the installer, not Vagrant?)

Yeah, sorry for the vague task, this is about the files generated in settings.d. (settings.d/wikis/<wiki>/LocalSettings.php also has wgLogo but maybe that's created by the installer, not Vagrant?)

@Tgr Maybe because of two files:

  1. puppet/modules/mediawiki/templates/multiwiki/LoadWgConf.php.erb:
  2. puppet/modules/role/manifests/labs_initial_content.pp

But, I will update it..

Change 594481 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/vagrant@master] Migrate from wgLogo to wgLogos

https://gerrit.wikimedia.org/r/594481

Change 594481 merged by jenkins-bot:
[mediawiki/vagrant@master] Migrate from wgLogo to wgLogos

https://gerrit.wikimedia.org/r/594481

Zoranzoki21 moved this task from Inbox to Watching on the User-Zoranzoki21 board.Sat, Aug 1, 10:43 PM

Change 594481 merged by jenkins-bot:
[mediawiki/vagrant@master] Migrate from wgLogo to wgLogos

https://gerrit.wikimedia.org/r/594481

This is merged, should we close task as resolved?

Tgr closed this task as Resolved.Sun, Aug 2, 2:59 PM
Tgr added a subscriber: bd808.

Thanks @Zoranzoki21 and @bd808!

Zoranzoki21 moved this task from Backlog to Done on the MediaWiki-Vagrant board.Sun, Aug 2, 7:20 PM

Your welcome @Tgr!