Page MenuHomePhabricator
Create Task
Maniphest T251961

Wikibase rows in enhanced recentchanges sometimes miss a separating space
Closed, ResolvedPublic
Actions

Description

Wikibase client's ChangeLineFormatter misses a word separator when used with enhanced recentchanges change grouping (where multiple changes to a single page are displayed together). This is relevant only for Wikibase changes that are displayed on a client wiki, not on the repository itself.

EnhancedChangesList-missing-space.png (172×780 px, 54 KB)
(Top: Expected result, Bottom: Actual result)

Details

SubjectRepoBranchLines +/-
ChangeLineFormatter: Add missing space for enhanced recentchangesmediawiki/extensions/Wikibasemaster+3 -2
Customize query in gerrit

Event Timeline

hoo created this task.May 6 2020, 12:11 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 6 2020, 12:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
hoo moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 6 2020, 12:12 AM
gerritbot added a comment.May 6 2020, 12:12 AM

Change 594546 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] ChangeLineFormatter: Add mising space for enhanced recentchanges

https://gerrit.wikimedia.org/r/594546

gerritbot added a project: Patch-For-Review.May 6 2020, 12:12 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 6 2020, 12:15 AM
Addshore triaged this task as Low priority.May 6 2020, 9:38 AM
gerritbot added a comment.May 6 2020, 9:58 AM

Change 594546 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ChangeLineFormatter: Add missing space for enhanced recentchanges

https://gerrit.wikimedia.org/r/594546

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 6 2020, 10:11 AM
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 6 2020, 11:27 AM
Lydia_Pintscher closed this task as Resolved.May 26 2020, 9:36 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lydia_Pintscher subscribed.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL