Page MenuHomePhabricator

Remove unused SpecialMobileCite class and related code from MobileFrontend
Closed, ResolvedPublic

Description

The class and related code are all unused. Should they be removed?

Event Timeline

xSavitar created this task.May 6 2020, 12:14 PM
Restricted Application added a project: User-xSavitar. · View Herald TranscriptMay 6 2020, 12:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.May 6 2020, 12:14 PM

Change 594318 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] specials: Remove unused SpecialMobileCite class and related code

https://gerrit.wikimedia.org/r/594318

Jdlrobson triaged this task as Low priority.May 8 2020, 2:32 PM

I ran a query on this one against a days worth of data (note I'm not taking into account the translated names of this page) and there were only 5 hits to this page. On that basis I'm happy to drop this page.

select count(*) from wmf.webrequest where day = 10 and month = 5 and year = 2020 AND uri_path LIKE "%MobileCite%";
select count(*) from wmf.webrequest where day = 10 and month = 5 and year = 2020 AND uri_path LIKE "%MobileCite%";

Thanks for this @Jdlrobson. I've added it to the commit message of the patch!

@ovasileva is it okay to break links to this artifact and remove this piece of code? Historically it was only ever in beta and it only got 5 hits in a single day across all our projects recently. The redirect is a bit useless e.g. clicking https://en.m.wikipedia.org/wiki/Special:MobileCite/Spain redirects to main page. If we remove that will simply 404.

@ovasileva is it okay to break links to this artifact and remove this piece of code? Historically it was only ever in beta and it only got 5 hits in a single day across all our projects recently. The redirect is a bit useless e.g. clicking https://en.m.wikipedia.org/wiki/Special:MobileCite/Spain redirects to main page. If we remove that will simply 404.

Sure, that's fine.

Change 594318 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] specials: Remove unused SpecialMobileCite class and related code

https://gerrit.wikimedia.org/r/594318