Maniphest T252014

Replace hamcrest global functions with namespaced class static functions
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Reedy
	May 6 2020, 1:32 PM

Description

From T181940: Remove composer dump-autoload --optimize from mw-fetch-composer-dev.sh and Quibble, it seems various hamcrest global functions are used in FileImporter

Would be worth swapping them out for their namespaced static functions equivalents

 * Decorates another Matcher, retaining the behavior but allowing tests
 * to be slightly more expressive.
 *
 * For example:  assertThat($cheese, equalTo($smelly))
 *          vs.  assertThat($cheese, is(equalTo($smelly)))
 */
function is($value)
{
    return \Hamcrest\Core\Is::is($value);
}

Related Objects

Mentioned Here: T181940: Remove composer dump-autoload --optimize from mw-fetch-composer-dev.sh and Quibble

Event Timeline

Reedy created this task.May 6 2020, 1:32 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMay 6 2020, 1:32 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald Transcript

What's the benefit of doing this? Is there a plan to drop Hamcrest's bootstrap and the "global functions file" it includes?

If so, how would a replacement look like? I played around a bit and found that the current

$this->assertThatHamcrest(
	$html,
	is( …

can be replaced with

use Hamcrest\Core\Is;
$this->assertThatHamcrest(
	$html,
	Is::is( …

But:

I find this harder to read.
The use section would grow quite significant.
It doesn't look like this is used anywhere, at the moment: https://codesearch.wmflabs.org/search/?q=Is::is

Aklapper added a project: Technical-Debt.Jun 1 2020, 10:00 AM

Aklapper removed a subscriber: Technical-Debt.

Not enough information given. Moving it out of our way for now.

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Nov 2 2020, 7:54 AM

No further information given. Please feel free to reopen this if you think this should still happen. The requested change itself is easy to do. I just would like to understand what the benefit is.

Replace hamcrest global functions with namespaced class static functionsClosed, DeclinedPublicActions

Description

Related Objects

Event Timeline

Replace hamcrest global functions with namespaced class static functions
Closed, DeclinedPublic
Actions