Page MenuHomePhabricator

Remove Wikibase assumption that a false dbname is the only way to refer to the local DB.
Closed, ResolvedPublic

Description

MediaWiki does not make this assumption, and DB connection code can handle the full string dbname / db domain ID and work as expected.
Wikbase however currently makes some different assumptions throughout the code base meaning false MUST be passed around in order to refer to the local DB.

This makes the work with EntitySources hard in terms of configuration.
Ideally we would deifne a set of entity sources for a cluster such as Wikimedia, and those same sources would be used on all wikis.
However due to the current assumptions we need to define different entity sources on the repo vs clients, as repo needs a false db name and clients need the string.

Event Timeline

Addshore claimed this task.May 6 2020, 1:55 PM
Addshore created this task.

Change 594714 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Stop assuming that string DB names mean non local DBs

https://gerrit.wikimedia.org/r/594714

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 6 2020, 2:15 PM

Change 594720 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseQualityConstraints@master] Stop assuming that string DB names mean non local DBs

https://gerrit.wikimedia.org/r/594720

Change 594714 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop assuming that string DB names mean non local DBs

https://gerrit.wikimedia.org/r/594714

Change 598544 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/core@master] ILoadBalancer::getConnection: Clarify when to reuseConnection

https://gerrit.wikimedia.org/r/598544

Change 598544 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Clarify ILoadBalancer::getConnection doc for when to call reuseConnection

https://gerrit.wikimedia.org/r/598544

Change 594720 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Stop assuming that string DB names mean non local DBs

https://gerrit.wikimedia.org/r/594720

Change 603572 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] CloneDatabase, add domain alias when prefix is changed

https://gerrit.wikimedia.org/r/603572

Addshore closed this task as Resolved.Jun 11 2020, 9:06 AM

The core of this is all deployed and working.
The CloneDatabase thing is only related

Change 603572 merged by jenkins-bot:
[mediawiki/core@master] CloneDatabase, add domain alias when prefix is changed

https://gerrit.wikimedia.org/r/603572