Page MenuHomePhabricator
Create Task
Maniphest T252043

Special:DeletedContributions: $row does not contain fields needed for comment rev_comment
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.31

message
$row does not contain fields needed for comment rev_comment

Impact

A couple of these in 1.35.0-wmf.31.

Notes

Tagging @DannyS712 as I'm guessing this is fallout from Revision refactoring.

Caused by 49707c59da2c4776b7752a5f2d5710f772c8d541

Details

Request ID
XrLe0gpAICsAAH--5pIAAABH
Request URL
https://www.mediawiki.org/wiki/Special:DeletedContributions/[user]
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.31/includes/CommentStore.php(410): CommentStore->getCommentInternal(Wikimedia\Rdbms\DBConnRef, string, array, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.31/includes/Revision/RevisionStore.php(1484): CommentStore->getCommentLegacy(Wikimedia\Rdbms\DBConnRef, string, stdClass, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.31/includes/Revision/RevisionStore.php(1342): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, NULL, integer, Title, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/pagers/DeletedContribsPager.php(303): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#4 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/pagers/DeletedContribsPager.php(260): DeletedContribsPager->formatRevisionRow(stdClass)
#5 /srv/mediawiki/php-1.35.0-wmf.31/includes/pager/IndexPager.php(585): DeletedContribsPager->formatRow(stdClass)
#6 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/SpecialDeletedContributions.php(113): IndexPager->getBody()
#7 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPage.php(576): SpecialDeletedContributions->execute(string)
#8 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPageFactory.php(618): SpecialPage->run(string)
#9 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(973): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(535): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.31/index.php(47): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
DeletedContribsPager: Revision rows are from the archive tablemediawiki/coremaster+1 -1
DeletedContribsPager: Revision rows are from the archive tablemediawiki/corewmf/1.35.0-wmf.31+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

brennen created this task.May 6 2020, 4:18 PM
Restricted Application added a project: Social-Tools. · View Herald TranscriptMay 6 2020, 4:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
brennen triaged this task as Unbreak Now! priority.May 6 2020, 4:24 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Unable to reproduce as I'm not an admin on mediawiki.org, but it's happened for multiple users so I'm guessing it likely breaks that view for all.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 6 2020, 4:24 PM
brennen added a parent task: T249963: 1.35.0-wmf.31 deployment blockers.May 6 2020, 4:24 PM
DannyS712 added a comment.May 6 2020, 4:25 PM
In T252043#6113439, @brennen wrote:

Unable to reproduce as I'm not an admin on mediawiki.org, but it's happened for multiple users so I'm guessing it likely breaks that view for all.

I am; can reproduce at https://www.mediawiki.org/wiki/Special:DeletedContributions/DannyS712. Looking now

DannyS712 claimed this task.May 6 2020, 4:27 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 6 2020, 4:28 PM
gerritbot added a comment.May 6 2020, 4:29 PM

Change 594751 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DeletedContribsPager: Revision rows are from the archive table

https://gerrit.wikimedia.org/r/594751

gerritbot added a project: Patch-For-Review.May 6 2020, 4:29 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.May 6 2020, 4:29 PM
DannyS712 added a comment.May 6 2020, 4:48 PM
In T252043#6113475, @gerritbot wrote:

Change 594751 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DeletedContribsPager: Revision rows are from the archive table

https://gerrit.wikimedia.org/r/594751

Tested with patch demo, confirmed to work:
http://patchdemo.wmflabs.org/wikis/862efa724e3b58f1a0b36a561c6fccb6/w/index.php/Special:DeletedContributions/Patch_Demo
(username: Patch Demo, password: patchdemo1)

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.May 6 2020, 4:50 PM
DannyS712 moved this task from Untriaged to Apr 2020 on the Wikimedia-production-error board.
DannyS712 edited projects, added Platform Team Workboards (External Code Reviews), MediaWiki-Comment-store, MediaWiki-Core-Revision-backend; removed Social-Tools, MediaWiki-extensions-Comments, Platform Engineering.
DannyS712 updated the task description. (Show Details)May 6 2020, 5:05 PM
DannyS712 moved this task from Apr 2020 to May 2020 on the Wikimedia-production-error board.May 6 2020, 5:28 PM
gerritbot added a comment.May 6 2020, 6:02 PM

Change 594768 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.31] DeletedContribsPager: Revision rows are from the archive table

https://gerrit.wikimedia.org/r/594768

gerritbot added a comment.May 6 2020, 6:16 PM

Change 594751 merged by jenkins-bot:
[mediawiki/core@master] DeletedContribsPager: Revision rows are from the archive table

https://gerrit.wikimedia.org/r/594751

gerritbot added a comment.May 6 2020, 6:19 PM

Change 594768 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.31] DeletedContribsPager: Revision rows are from the archive table

https://gerrit.wikimedia.org/r/594768

Ammarpad added a subtask: T252052: Fix Undefined property: stdClass::$ar_id from Revision/RevisionArchiveRecord.php line 74.May 6 2020, 6:26 PM
Stashbot added a comment.May 6 2020, 6:28 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-06T18:28:57Z] <twentyafterfour@deploy1001> Synchronized php-1.35.0-wmf.31/includes/specials/pagers/DeletedContribsPager.php: sync https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/594768/ fixes T252043 (duration: 01m 08s)

DannyS712 closed this task as Resolved.May 6 2020, 6:29 PM
DannyS712 removed a project: Patch-For-Review.

https://www.mediawiki.org/wiki/Special:DeletedContributions/DannyS712 now works

DannyS712 removed a subtask: T252052: Fix Undefined property: stdClass::$ar_id from Revision/RevisionArchiveRecord.php line 74.May 6 2020, 6:29 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 7:00 PM
DannyS712 mentioned this in T249964: 1.35.0-wmf.32 deployment blockers.May 11 2020, 5:19 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM
adrelanos mentioned this in T276782: FlaggedRevs: reviewAllPages.php CommentStore.php: $row does not contain fields needed for comment rev_comment.Mar 8 2021, 12:45 PM
adrelanos subscribed.

Might not be fully fixed: T276782

Winston_Sung mentioned this in T344971: Migrate Database::select usages to SelectQueryBuilder in MediaWiki core.Dec 18 2023, 6:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits