Page MenuHomePhabricator

pre-save transform may occur outside section being edited
Open, LowPublic

Description

Author: M8R-cyc3n3

Description:
I noticed the pre-save transform affects the entire
page, not just the section you are editing. If through
some trickery or foresight you create a page like this:

Section 1

{{subst:template which doesn't exist yet}}
{{subst:#some future parser-func:foo|bar}}

Section 2

Lorem ipsum

A subsequent edit to Section 2 may cause unexpected
changes to the wiki-text of Section 1 if and when the
requested subst-items exist.

Seems like the least astonishing behavior would be to
prevent this.


Version: unspecified
Severity: enhancement

Details

Reference
bz23205

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:05 PM
bzimport set Reference to bz23205.
bzimport added a subscriber: Unknown Object (MLST).

When you're editing a section, you're really editing the whole page. There's no difference between it and opening the full page to only edit a section. While the behavior isn't necessarily intuitive, it is expected. Not sure of any clean way to really change this...WONTFIX?

M8R-cyc3n3 wrote:

When you're editing a section, you're really editing
the whole page. There's no difference between it and
opening the full page to only edit a section.

I realize they're all part of the same page, but I still
think section-edits should provide a basic guarantee not
to change any text which is not part of the edit form.

While the behavior isn't necessarily intuitive, it is
expected.

I'd go further and say it is never intuitive.

demon removed a subscriber: demon.Aug 19 2015, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 5:23 PM