Page MenuHomePhabricator

Fix Undefined property: stdClass::$ar_id from Revision/RevisionArchiveRecord.php line 74
Closed, ResolvedPublic

Description

It does not yet occur, but it will once r594751 is deployed. The patch was merged while I was writing comment to point this out.

Event Timeline

Ammarpad created this task.May 6 2020, 6:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2020, 6:22 PM
Ammarpad renamed this task from Fix Undefined property: stdClass::$ar_id from Revision/RevisionArchiveRecord.p line 74 to Fix Undefined property: stdClass::$ar_id from Revision/RevisionArchiveRecord.php line 74.May 6 2020, 6:26 PM
Ammarpad updated the task description. (Show Details)

@Ammarpad can you post a stack trace?

Change 594776 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Complete required fields for RevisionFactory::newRevisionFromArchiveRow

https://gerrit.wikimedia.org/r/594776

mmodell added a subscriber: mmodell.May 6 2020, 6:33 PM

confirmed, it's showing up in logstash

Stacktrace:

#0 /srv/mediawiki/php-1.35.0-wmf.31/includes/Revision/RevisionArchiveRecord.php(74): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.31/includes/Revision/RevisionStore.php(1425): MediaWiki\Revision\RevisionArchiveRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.31/includes/Revision/RevisionStore.php(1320): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, array)
#3 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/pagers/DeletedContribsPager.php(303): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRow(stdClass, integer, Title)
#4 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/pagers/DeletedContribsPager.php(260): DeletedContribsPager->formatRevisionRow(stdClass)
#5 /srv/mediawiki/php-1.35.0-wmf.31/includes/pager/IndexPager.php(585): DeletedContribsPager->formatRow(stdClass)
#6 /srv/mediawiki/php-1.35.0-wmf.31/includes/specials/SpecialDeletedContributions.php(113): IndexPager->getBody()
#7 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPage.php(576): SpecialDeletedContributions->execute(string)
#8 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPageFactory.php(618): SpecialPage->run(string)
#9 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(973): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(535): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.31/index.php(47): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

@Ammarpad can you post a stack trace?

Change 594778 had a related patch set uploaded (by 20after4; owner: Ammarpad):
[mediawiki/core@wmf/1.35.0-wmf.31] Complete required fields for RevisionFactory::newRevisionFromArchiveRow

https://gerrit.wikimedia.org/r/594778

cherry picked the patch to wmf.31 and +2'd it

@Ammarpad can you post a stack trace?

Wow, not sure how I missed that

mmodell triaged this task as Unbreak Now! priority.May 6 2020, 6:41 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 6 2020, 6:41 PM

Change 594778 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.31] Complete required fields for RevisionFactory::newRevisionFromArchiveRow

https://gerrit.wikimedia.org/r/594778

Mentioned in SAL (#wikimedia-operations) [2020-05-06T18:58:21Z] <twentyafterfour@deploy1001> Synchronized php-1.35.0-wmf.31/includes/specials/pagers/DeletedContribsPager.php: deploy https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/594778/ fixes UBN T252052 (duration: 01m 09s)

mmodell closed this task as Resolved.May 6 2020, 7:00 PM
mmodell claimed this task.

patch deployed and the error appears to be fixed.

Change 594776 merged by jenkins-bot:
[mediawiki/core@master] Complete required fields for RevisionFactory::newRevisionFromArchiveRow

https://gerrit.wikimedia.org/r/594776

Aklapper removed a subscriber: 20after4.May 6 2020, 7:27 PM