Page MenuHomePhabricator

Support signatures where the timestamp is a link
Closed, ResolvedPublic

Description

For example in https://fr.wikipedia.org/wiki/Mod%C3%A8le:Non_sign%C3%A9 the timestamp can link to a diff

Event Timeline

This can probably be done by adding .parentNode somewhere in parser#findSignature if we discover that timestampNode is wrapped in a link.

Change 599118 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Support parsing when timestamp is wrapped in a link

https://gerrit.wikimedia.org/r/599118

Change 599119 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Tests covering fr.wp unsigned comment templates

https://gerrit.wikimedia.org/r/599119

Change 599118 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Support parsing when timestamp is wrapped in a link

https://gerrit.wikimedia.org/r/599118

Change 599119 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Tests covering fr.wp unsigned comment templates

https://gerrit.wikimedia.org/r/599119

matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

I've been using this page for testing: https://fr.wikipedia.org/wiki/Discussion:Le_Monde#Mort_de_Pierre_Berge

There are two unsigned comments in that section. After this patch goes live, they should both get a "Reply" link. (You might get an error after clicking them, that's expected for now and covered by T252058.)