Maniphest T252072

Special:RevisionReview: PHP Unknown error: Object of class MediaWiki\Revision\RevisionStoreRecord could not be converted to string
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	May 6 2020, 8:56 PM

Description

Error

MediaWiki version: 1.35.0-wmf.31

message

PHP Unknown error: Object of class MediaWiki\Revision\RevisionStoreRecord could not be converted to string

Impact

~8 of these since deploy of 1.35.0-wmf.31.

Notes

Caused by 49707c59da2c4776b7752a5f2d5710f772c8d541

Details

Request ID: XrMhuwpAICMAAEE76ecAAACB
Request URL: https://en.wikibooks.org/w/index.php?title=Special:RevisionReview&action=submit

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.31/includes/GlobalFunctions.php(1809): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.31/languages/Language.php(2407): wfTimestamp(integer, MediaWiki\Revision\RevisionStoreRecord)
#2 /srv/mediawiki/php-1.35.0-wmf.31/languages/Language.php(2492): Language->internalUserTimeAndDate(string, MediaWiki\Revision\RevisionStoreRecord, User, array)
#3 /srv/mediawiki/php-1.35.0-wmf.31/includes/revisionlist/RevisionItem.php(98): Language->userTimeAndDate(MediaWiki\Revision\RevisionStoreRecord, User)
#4 /srv/mediawiki/php-1.35.0-wmf.31/includes/revisionlist/RevisionItem.php(149): RevisionItem->getRevisionLink()
#5 /srv/mediawiki/php-1.35.0-wmf.31/extensions/FlaggedRevs/frontend/RejectConfirmationFormUI.php(117): RevisionItem->getHTML()
#6 /srv/mediawiki/php-1.35.0-wmf.31/extensions/FlaggedRevs/frontend/specialpages/actions/RevisionReview.php(95): RejectConfirmationFormUI->getHtml()
#7 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPage.php(576): RevisionReview->execute(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.31/includes/specialpage/SpecialPageFactory.php(618): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(973): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.31/includes/MediaWiki.php(535): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.31/index.php(47): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	RevisionItem: Fix providing timestamp in getRevisionLink	mediawiki/core	wmf/1.35.0-wmf.31	+1 -1
	RevisionItem: Fix providing timestamp in getRevisionLink	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	brennen	T249963 1.35.0-wmf.31 deployment blockers
		Resolved	PRODUCTION ERROR	DannyS712	T252072 Special:RevisionReview: PHP Unknown error: Object of class MediaWiki\Revision\RevisionStoreRecord could not be converted to string

Event Timeline

brennen created this task.May 6 2020, 8:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2020, 8:56 PM

brennen renamed this task from PHP Unknown error: Object of class MediaWiki\Revision\RevisionStoreRecord could not be converted to string to Special:RevisionReview: PHP Unknown error: Object of class MediaWiki\Revision\RevisionStoreRecord could not be converted to string.May 6 2020, 8:57 PM

brennen triaged this task as Unbreak Now! priority.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 6 2020, 8:57 PM

brennen added a parent task: T249963: 1.35.0-wmf.31 deployment blockers.May 6 2020, 8:57 PM

brennen updated the task description. (Show Details)May 6 2020, 9:00 PM

@DannyS712: cause: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/593620/18/includes/revisionlist/RevisionItem.php#98

My bad, missed it in the review :(

In T252072#6114497, @Pchelolo wrote:

@DannyS712: cause: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/593620/18/includes/revisionlist/RevisionItem.php#98

My bad, missed it in the review :(

Change 594802 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RevisionItem: Fix providing timestamp in getRevisionLink

https://gerrit.wikimedia.org/r/594802

gerritbot added a project: Patch-For-Review.May 6 2020, 9:09 PM

DannyS712 claimed this task.May 6 2020, 9:10 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 6 2020, 9:10 PM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.May 6 2020, 9:10 PM

DannyS712 moved this task from Untriaged to May 2020 on the Wikimedia-production-error board.

DannyS712 updated the task description. (Show Details)

Change 594803 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.31] RevisionItem: Fix providing timestamp in getRevisionLink

https://gerrit.wikimedia.org/r/594803

Change 594802 merged by jenkins-bot:
[mediawiki/core@master] RevisionItem: Fix providing timestamp in getRevisionLink

https://gerrit.wikimedia.org/r/594802

Change 594803 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.31] RevisionItem: Fix providing timestamp in getRevisionLink

https://gerrit.wikimedia.org/r/594803

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 6 2020, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 6 2020, 10:10 PM

DannyS712 closed this task as Resolved.May 6 2020, 10:27 PM

DannyS712 mentioned this in T249964: 1.35.0-wmf.32 deployment blockers.May 11 2020, 5:19 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM