Page MenuHomePhabricator

Cover RevisionList/RevisionItem classes with tests
Closed, ResolvedPublic

Description

Simple refactoring of RevisionList/RevisionItem classes recently has ended up in two train blockers. This code is completely not covered with tests. We need to create tests for all the code residing in includes/revisionlist

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 594807 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/594807

Change 594807 merged by jenkins-bot:
[mediawiki/core@master] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/594807

Change 596022 had a related patch set uploaded (by Hashar; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.32] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/596022

Change 596022 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.32] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/596022

Mentioned in SAL (#wikimedia-operations) [2020-05-12T20:15:42Z] <hashar@deploy1001> Synchronized php-1.35.0-wmf.32/includes/revisionlist/RevisionItemBase.php: Fix RevisionItemBase::getId to actually return an int, as intended - T252076 (duration: 01m 06s)

Good enough for now?

Yeah, looks good to me for now

RevisionItem.php - 40% of lines, 75% of methods covered
RevisionItemBase.php - 69.57%, 71.43%
RevisionList.php - 100%, 100%
RevisionListBase.php - 74.07%, 63.64%

Good enough for now?

Yeah, looks good to me for now

I was asking @Pchelolo as the person who filed the task, but sure. :-)

I was asking @Pchelolo as the person who filed the task, but sure. :-)

Oh I missed it. yeah, looks good.