Page MenuHomePhabricator
Create Task
Maniphest T252076

Cover RevisionList/RevisionItem classes with tests
Closed, ResolvedPublic
Actions

Description

Simple refactoring of RevisionList/RevisionItem classes recently has ended up in two train blockers. This code is completely not covered with tests. We need to create tests for all the code residing in includes/revisionlist

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add tests for RevisionList/RevisionItem classesHasharmediawiki/corewmf/1.35.0-wmf.32+247 -1
Add tests for RevisionList/RevisionItem classesDannyS712mediawiki/coremaster+247 -1
Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.May 6 2020, 9:30 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 6 2020, 9:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Pchelolo moved this task from Inbox to Tracking/Watching on the Platform Engineering board.May 6 2020, 9:31 PM
Gabrielchl updated the task description. (Show Details)May 6 2020, 11:19 PM
DannyS712 added a project: Test-Coverage.May 6 2020, 11:30 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 mentioned this in T252170: Expand code coverage in the includes/Revision/ directory.May 7 2020, 9:15 PM
gerritbot added a comment.May 7 2020, 10:57 PM

Change 594807 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/594807

gerritbot added a project: Patch-For-Review.May 7 2020, 10:57 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.May 7 2020, 10:58 PM
DannyS712 mentioned this in T249964: 1.35.0-wmf.32 deployment blockers.May 11 2020, 5:29 PM
gerritbot added a comment.May 12 2020, 5:57 PM

Change 594807 merged by jenkins-bot:
[mediawiki/core@master] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/594807

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 12 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 6:10 PM
Jdforrester-WMF subscribed.May 12 2020, 6:15 PM

Good enough for now?

gerritbot added a comment.May 12 2020, 7:08 PM

Change 596022 had a related patch set uploaded (by Hashar; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.32] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/596022

gerritbot added a project: Patch-For-Review.May 12 2020, 7:08 PM
gerritbot added a comment.May 12 2020, 8:12 PM

Change 596022 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.32] Add tests for RevisionList/RevisionItem classes

https://gerrit.wikimedia.org/r/596022

Stashbot added a comment.May 12 2020, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-12T20:15:42Z] <hashar@deploy1001> Synchronized php-1.35.0-wmf.32/includes/revisionlist/RevisionItemBase.php: Fix RevisionItemBase::getId to actually return an int, as intended - T252076 (duration: 01m 06s)

DannyS712 removed a project: Patch-For-Review.May 12 2020, 8:18 PM
ReleaseTaggerBot edited projects, added: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 12 2020, 9:00 PM
DannyS712 added a comment.May 13 2020, 7:45 PM
In T252076#6130528, @Jdforrester-WMF wrote:

Good enough for now?

Yeah, looks good to me for now

RevisionItem.php - 40% of lines, 75% of methods covered
RevisionItemBase.php - 69.57%, 71.43%
RevisionList.php - 100%, 100%
RevisionListBase.php - 74.07%, 63.64%

DannyS712 closed this task as Resolved.May 13 2020, 7:45 PM
Jdforrester-WMF added a comment.May 13 2020, 7:48 PM
In T252076#6134890, @DannyS712 wrote:
In T252076#6130528, @Jdforrester-WMF wrote:

Good enough for now?

Yeah, looks good to me for now

I was asking @Pchelolo as the person who filed the task, but sure. :-)

• Pchelolo added a comment.May 13 2020, 8:03 PM

I was asking @Pchelolo as the person who filed the task, but sure. :-)

Oh I missed it. yeah, looks good.

DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.May 27 2020, 8:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits