Page MenuHomePhabricator

Use MediaWikiServices::getLanguageConverterFactory instead of Language::getConverter
Closed, DeclinedPublic

Description

Language::getConverter is soft deprecated and used 27+ times. Most of them are self-calls (from Language class)

Expected result

  • Use MediaWikiServices::getLanguageConverterFactory instead of Language::getConverter
  • hard deprecate Language::getConverter
  • make protected after 1.36 version

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2020, 3:44 AM
Art-Baltai updated the task description. (Show Details)May 7 2020, 3:46 AM
Art-Baltai updated the task description. (Show Details)May 7 2020, 12:22 PM

@Art-Baltai: Assuming this task is about the MediaWiki-Language-converter code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Peter.ovchyn closed this task as Declined.May 30 2020, 9:06 AM

Close this task as it's a duplication of T254004 and T252095.
No need to avoid internal use of getConverter as it's convenience shortcut,
External use better to avoid as part of T252095.