Page MenuHomePhabricator
Create Task
Maniphest T252092

Use MediaWikiServices::getLanguageConverterFactory instead of Language::getConverter
Closed, DeclinedPublic
Actions

Description

Language::getConverter is soft deprecated and used 27+ times. Most of them are self-calls (from Language class)

Expected result

  • Use MediaWikiServices::getLanguageConverterFactory instead of Language::getConverter
  • hard deprecate Language::getConverter
  • make protected after 1.36 version

Related Objects

Event Timeline

Art-Baltai created this task.May 7 2020, 3:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2020, 3:44 AM
Art-Baltai updated the task description. (Show Details)May 7 2020, 3:46 AM
Art-Baltai updated the task description. (Show Details)May 7 2020, 12:22 PM
Aklapper added a project: MediaWiki-Language-converter.May 15 2020, 1:40 PM

@Art-Baltai: Assuming this task is about the MediaWiki-Language-converter code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Peter.ovchyn closed this task as Declined.May 30 2020, 9:06 AM

Close this task as it's a duplication of T254004 and T252095.
No need to avoid internal use of getConverter as it's convenience shortcut,
External use better to avoid as part of T252095.

Peter.ovchyn removed a project: Platform Team Workboards (S&F Workboard).May 30 2020, 9:07 AM
Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Dec 27 2023, 6:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL