Page MenuHomePhabricator
Create Task
Maniphest T252170

Expand code coverage in the includes/Revision/ directory
Closed, ResolvedPublic
Actions

Description

Mostly covered, but a number of recent failures

See also T252076

Current coverage can be found at https://doc.wikimedia.org/cover/mediawiki-core/includes/Revision/index.html

Specific classes with low coverage:
RenderedRevision - 46.15% of functions and methods
RevisionRenderer - 33.33% of functions and methods
RevisionStore - 51.47% of functions and methods

Details

SubjectRepoBranchLines +/-
Add some tests for RevisionStore helper methodsmediawiki/coremaster+84 -0
Test exceptions thrown in RevisionStore::checkContentmediawiki/coremaster+103 -0
Bring RevisionRecord code coverage to 100%mediawiki/coremaster+25 -0
Test exceptions thrown in RenderedRevisionmediawiki/coremaster+42 -0
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.May 7 2020, 9:15 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 7 2020, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 claimed this task.May 7 2020, 9:15 PM
DannyS712 triaged this task as Medium priority.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.May 7 2020, 9:21 PM

Change 595053 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Bring RevisionRecord code coverage to 100%

https://gerrit.wikimedia.org/r/595053

gerritbot added a project: Patch-For-Review.May 7 2020, 9:21 PM
gerritbot added a comment.May 9 2020, 10:00 PM

Change 595295 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Test exceptions thrown in RenderedRevision

https://gerrit.wikimedia.org/r/595295

gerritbot added a comment.Jun 2 2020, 12:03 AM

Change 595295 merged by jenkins-bot:
[mediawiki/core@master] Test exceptions thrown in RenderedRevision

https://gerrit.wikimedia.org/r/595295

gerritbot added a comment.Jun 2 2020, 12:40 AM

Change 595053 merged by jenkins-bot:
[mediawiki/core@master] Bring RevisionRecord code coverage to 100%

https://gerrit.wikimedia.org/r/595053

gerritbot added a comment.Jun 2 2020, 12:47 AM

Change 601495 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Test exceptions thrown in RevisionStore::checkContent

https://gerrit.wikimedia.org/r/601495

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).Jun 2 2020, 1:00 AM
Krinkle moved this task from Untriaged to Revision on the MediaWiki-Core-Revision-backend board.Mar 2 2022, 8:35 PM
gerritbot added a comment.Jun 3 2022, 9:46 PM

Change 601495 abandoned by DannyS712:

[mediawiki/core@master] Test exceptions thrown in RevisionStore::checkContent

Reason:

https://gerrit.wikimedia.org/r/601495

gerritbot added a comment.Jun 3 2022, 9:48 PM

Change 802829 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Add tests for RevisionStore helper methods

https://gerrit.wikimedia.org/r/802829

gerritbot added a comment.Jun 6 2022, 6:57 AM

Change 802829 merged by jenkins-bot:

[mediawiki/core@master] Add some tests for RevisionStore helper methods

https://gerrit.wikimedia.org/r/802829

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 6 2022, 7:00 AM
Aklapper closed this task as Resolved.Aug 16 2022, 12:33 PM
Aklapper removed a project: Patch-For-Review.

Boldly closing as resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL