Page MenuHomePhabricator

Page Forms 4.9 and 4.9.1, action=formedit goes to infinite loop on some pages
Closed, ResolvedPublic


With Page Forms 4.9 and 4.9.1, action=formedit times out on some pages. This does not happen with 4.8.

Some example traces:

( ! ) Fatal error: Maximum execution time of 5 seconds exceeded in /srv/mediawiki/workdir/extensions/PageForms/includes/PF_PageSection.php on line 33
Call Stack
#	Time	Memory	Function	Location
1	0.0003	402648	{main}( )	.../index.php:0
2	0.2228	6192624	MediaWiki->run( )	.../index.php:42
3	0.2451	6686768	MediaWiki->main( )	.../MediaWiki.php:515
4	0.2582	6854808	MediaWiki->performRequest( )	.../MediaWiki.php:865
5	0.2754	7176384	MediaWiki->performAction( )	.../MediaWiki.php:294
6	0.2759	7176688	PFFormEditAction->show( )	.../MediaWiki.php:499
7	0.2760	7176688	PFFormEditAction::displayForm( )	.../PF_FormEditAction.php:32
8	0.2802	7308856	PFFormEdit->printForm( )	.../PF_FormEditAction.php:310
9	0.2922	7545984	PFAutoeditAPI->execute( )	.../PF_FormEdit.php:104
10	0.3246	8358640	PFAutoeditAPI->doAction( )	.../PF_AutoeditAPI.php:115
11	0.3564	8728448	StubObject->formHTML( )	.../PF_AutoeditAPI.php:914
12	0.3564	8728824	StubObject->__call( )	.../PF_AutoeditAPI.php:914
13	0.3564	8728824	StubObject->_call( )	.../StubObject.php:138
14	0.3698	8975688	PFFormPrinter->formHTML( )	.../StubObject.php:112
15	26.0780	12803776	PFPageSection::newFromFormTag( )	.../PF_FormPrinter.php:1408
( ! ) Fatal error: Maximum execution time of 5 seconds exceeded in /srv/mediawiki/workdir/extensions/PageForms/includes/PF_Utils.php on line 370
Call Stack
#	Time	Memory	Function	Location
1	0.0000	401376	{main}( )	.../index.php:0
2	0.0091	4175832	MediaWiki->run( )	.../index.php:42
3	0.0126	4937472	MediaWiki->main( )	.../MediaWiki.php:515
4	0.0135	5105320	MediaWiki->performRequest( )	.../MediaWiki.php:865
5	0.0142	5292688	MediaWiki->performAction( )	.../MediaWiki.php:294
6	0.0144	5292992	PFFormEditAction->show( )	.../MediaWiki.php:499
7	0.0144	5292992	PFFormEditAction::displayForm( )	.../PF_FormEditAction.php:32
8	0.0148	5359144	PFFormEdit->printForm( )	.../PF_FormEditAction.php:310
9	0.0152	5595440	PFAutoeditAPI->execute( )	.../PF_FormEdit.php:104
10	0.0174	6317528	PFAutoeditAPI->doAction( )	.../PF_AutoeditAPI.php:115
11	0.0226	6488408	StubObject->formHTML( )	.../PF_AutoeditAPI.php:914
12	0.0226	6488784	StubObject->__call( )	.../PF_AutoeditAPI.php:914
13	0.0226	6488784	StubObject->_call( )	.../StubObject.php:138
14	0.0230	6732720	PFFormPrinter->formHTML( )	.../StubObject.php:112
15	24.2253	10003768	PFUtils::getFormTagComponents( )	.../PF_FormPrinter.php:1407
16	24.2253	10003768	PFUtils::smartSplitFormTag( )	.../PF_Utils.php:407

Here's the page content

|kategoria=Juhlat ja tavat
|asiasanat=festive traditions, bonfires, annual festivals, Easter, events, folk belief systems, village activity, social interaction, witches, magic, witchcraft, livelihood magic

==Practitioners and people who know the tradition well==
The Ostrobothnian Easter bonfire tradition has been, and still is, practised in its core regions of Central, Southern and Northern Ostrobothnia. The tradition is kespt alive by lighting small building or family-specific fires and organising local village festivities with common village bonfires. When building family bonfires, everyone can join the men of the house in the work, even children. These days, village associations and other organisations, such as farmers’ associations and sports clubs, organise village bonfire events, keeping the tradition of communal work alive. The bonfire squares are meeting places for people of all ages, where they can see their friends and socialise with each other. Everyone is welcome to the bonfire, including people driving in from further away to see the fire. The Easter fire tradition is still alive among people of all ages, and it has found new communal forms, for example in the operations of village associations.
[[Tiedosto:Kokko palaa komiasti pääsiäisen merkiksi ja vanhan perinteen mukaisestiKuva 136.JPG|thumb|Bonfire burns nicely according to the Easter traditions. Photo: Johanna Junno.|269x269px]]

==Practising of the tradition==
The Easter fire tradition is still a living folk tradition in Central, Southern and Northern Ostrobothnia. Family bonfires are usually lit in the early evening and the village bonfires a little later. Building bonfires and collecting materials for them is often started weeks before the night that the fires are lit on; however, the bonfire is not built until in the morning of the day it is lit or a few days before lighting it on Holy Saturday. Often, the villagers sell coffee and hot sausages near the bonfire and hold raffles. Trullis – small children dressed as Easter witches – are given a small reward for attending the bonfire celebrations. The Easter bonfire tradition is maintained among people of all ages through the participation in building the bonfire, gathering around it, seeing friends and socialising and spending time among family or with the villagers and people passing by. When the bonfires are burning, the people talk about the traditional beliefs related to bonfires and trullis, passing them on. Trullis are still a part of the Ostrobothnian Easter, as the children go from house to house dressed as witches. [[Tiedosto:Suurkokkotapahtuma Ylivieskan raviradalla 1992Img128.jpg|thumb|Large regional bonfire event at Ylivieska racetrack at the beginning of 1990s. People of all ages have gathered around the bonfire. Photo: Johanna Junno.|269x269px]]

Three different forms of this tradition have been identified: family or building-specific, smaller bonfires, i.e. so-called family bonfires; village bonfires; and regional bonfires. In the 1990s, all three forms of this tradition were still present. In the 2000s, the large regional bonfires have mostly disappeared and they have been replaced by village bonfires, which are built and lit by village associations and other organisations through communal work.

The large bonfires were lit, for example, at Keskinen horse racetrack in Ylivieska in the 1990s, when the bonfire attracted crowds of up to 4,000 visitors. This was an hours-long bonfire event with different programmes, such as a trulli-witch competition and a horse race, as well as coffee canteens and raffles, and the event was crowned by lighting the bonfire. People from the surrounding 100 km or so area came together at the large bonfire.

The village bonfire and family bonfire traditions are still alive parallel to each other. In particular, rural families with children build family bonfires. Family and village bonfires are a part of rural traditions, and bonfires are not allowed in suburbs or cities due to the denser population.

During the evening and night of Holy Saturday, people drive by car to see the bonfires, and sometimes they stop at a bonfire to meet the people and admire the fire.
[[Tiedosto:Trullikilpailu Ylivieskan raviradan suurkokkotapahtumassa 1992Img130.jpg|thumb|Trulli competition at the large bonfire event at Ylivieska horse racetrack in the early 1990s. The trullis prepared performances. Photo: Johanna Junno.|271x271px]]

The trulli and witch competitions of village bonfires attract children and the young at heart alike, and they are one of the event’s fun and lively parts even today. Trulli competitions are playful show competitions for trullis, where usually all participants receive a small reward. In the 1990s, a trulli competition was held in connection with the regional bonfire in Ylivieska. In the competition, children dressed up as Easter witches performed little shows for the public. The trullis were interviewed and they presented themselves and maybe performed a song or a dance. Playful beauty or ugliness competitions, for example, have been held at the village bonfires. In Easter 2016, for example, there was a woman dressed as a trulli at Raudaskylä village bonfire, who gave out candy from a basket she was holding and wished everyone happy Easter.

==The background and history of the tradition==
The tradition of lighting Easter fires has a history of several hundred years. Fires have been a part of festivals related to different phases of the year and calendarial celebrations in different parts of Europe. Bonfires are also lit on Shrove Tuesday, Midsummer’s Eve and May Day, as well as during spring and harvest feasts, all of which can still be seen in some places. In the old traditions, bonfires have been either harvest or banishment fires. The oldest bonfire traditions probably date back to pre-Christian times. The Easter fire tradition in Ostrobothnia has some resemblance to the witch banishing fires in Southern Sweden and Southern Europe. In the Ostrobothnia region, Easter fires, ‘valkia’ by their Southern Ostrobothnian name, became an established part of the celebrations in the 18th century. Beliefs related to the harvest year have been connected to the bonfires and they have been burned on the fields in the belief that the smoke and ash would guarantee a plentiful harvest. In addition to this, there are several beliefs about Easter bonfires that are related to their abilities to repel witches and banish evil. It was believed that witches and trullis were unable to fly because they could not see through the smoke and that trullis were afraid of living fire. Furthermore, fire has universal, symbolic significance as a protective, purifying element. 
[[Tiedosto:Pääsiäiskokko tehdään aidoista aineksista mm. oljista ja havuista.Img133.jpg|thumb|An Easter bonfire is made of authentic bonfire materials, such as straw and evergreen branches. Photo: Johanna Junno.|274x274px]]
In Finland, at least in Ostrobothnia, jealous ‘witches’ visited the stables of their neighbours after war times and as late as in the 1960s, doing some mischief to the cattle. During Lent, and especially on Holy Saturday, these ‘witches’ cut off hair from cows’ tails or sheared some wool off sheep. Behind this tradition was an old belief, according to which there is only a certain, limited amount of goodness in the world, and you had to steal some from someone else so that there was enough for you. Easter bonfires were lit to banish or reveal these mischief-makers. Other magical measures were also used for protection against evil. 
Bonfires were also lit to celebrate the event. Before, Easter bonfires were mainly intended for the young people and they were venues for socialising and meeting each other. Today, lighting bonfires is a celebration for the entire village where everyone is welcome, even passers-by.

==The transmission of the tradition==
The Easter bonfire tradition is repeated every year around Southern and Central Ostrobothnia. Different parties build and light the bonfires. When the fires are burning, people tell stories about the traditional beliefs related to them, passing on the oral tradition that is an essential part of the bonfires. Burning bonfires is a tradition and established habit that has been maintained for several centuries. 

The tradition is passed on to children through family bonfires and to people of all ages through village bonfires. Building the bonfires through communal work with, for example, village and farming associations and sports societies is also a form of modern communality. The bonfire squares are meeting places for people of all ages, where they can see their friends and socialise with each other. Everyone is welcome to the bonfire, including people driving in from further away to see the fire. Bonfire events are open and public in nature. There are advertisements about the bonfires in magazines and media, so the public is notified of the events.

The parallel forms of the bonfire tradition, the family and village bonfires, further strengthen and support the preservation and continuance of the tradition. The Easter bonfire tradition has survived to this day and has been able to adapt to the activities and life of modern people. This is a sign of the strength and vitality of this tradition. A function has been found for it in today’s world. People in Southern and Central Ostrobothnia are aware and proud of their Easter bonfire tradition and its uniqueness to these areas. The borders of the bonfire tradition have remained much the same with regard to Easter bonfires, but Midsummer’s Eve bonfires have become more common all over the country with summer cabin residents. 

Lighting Easter bonfires is a habit and an annual ritual with communal approval. The folk belief and livelihood magic backgrounds related to agrarian culture are still present in the Easter fire tradition and its oral traditions. The history of bonfires is shared and the different generations come together to remember their experiences of both old and new forms of the tradition. The media also bring up these.
[[Tiedosto:Kyläkokko sievin järvikyläImg129.jpg|thumb|Village bonfire in Järvikylä, Sievi, at the beginning of 1990s. Photo: Johanna Junno.|268x268px]]
The bonfire tradition reinforces communal feeling and identity, but also entrepreneurship, capability and vitality of the villages. Today, small trulli-witches are invited to the bonfire events, whereas before the bonfires were used to repel witches. Witches have kept their place in the bonfire tradition of today. The mischief done by jealous adults in the past has transformed into a children’s tradition with costumes and going from house to house. The small witches tour the neighbourhood on the morning of Holy Saturday, carrying coffee pots, and it is important that the neighbours have some treats to give them, as it is a bad omen for the house if they cannot reward them with anything.

==The future of the tradition==
The Easter bonfire tradition is still going strong in Southern and Central Ostrobothnia. The number of village bonfire events has increased and families still light family bonfires. Large regional bonfire events have not been arranged much during the 2000s. The tradition will remain a strong form of custom and festive culture, as it has been able to adapt to the needs of modern-day people. As long as the rural areas remain alive, the tradition will live on through new variations. The belief and touring from house to house traditions related to the tradition will continue to promote the vitality and continuance of this tradition in the future. The tradition is not intended and conserved just for people of certain ages, but it is intended for all.

==The communities behind this submission.==
[ The provincial museum of South Ostrobothnia], Seinäjoki

[ Peräseinäjoen Viitalan Nuorisoseura ry] (Seinäjoki) 

Hanhikosken kyläseura, Ylistaro (Seinäjoki)

[ Kihniänkylän nuorisoseura] (Peräseinäjoki)

[ Könnin kyläseura ry] (Ilmajoki)

[ Luovan Kyläseura Ry] (Kurikka)

[ Munakan nuorisoseura] (Ilmajoki)

[ Tuiskulan kyläseura] (Kurikka)

==Bibliography and links to external sources of information==
'''Written sources:'''

Junno-Pennanen Johanna, Kellä kommein kokko - Pääsiäiskokkoperinne Pohjanmaalla. Perinteentutkimuksen pro gradu tutkielma 1999 It'-Suomen yliopisto. 1999.

Junno-Pennanen Johanna, kenttätyöaineistot (haastattelut, ainekirjoitukset, havainnoinnit,  valokuvat ja sanomalehdet).

Harva Uno, Suomalaisten muinaisusko, Helsinki 1948.

Helminen  Helmi, Kansanomainen ajanlasku ja vuotuisjuhlat. Suomen kulttuurihistoria I 1933.

Mansikka V.J., Kokkotulista. Virittäjä Helsinki 1940.

Sarmela Matti, Julkaisematon käsikirjoitus juhlatulista 1993.

Sarmela Matti, Suomen perinneatlas, Suomen kansankulttuurin kartasto 2, SKS Helsinki 1994.

Vilkuna Kustaa, Vuotuinen ajantieto Helsinki 1950, 1980 ja 1988.

'''Archival sources:'''

Museovirasto. Keruukilpailu nro 30/1983. Kyselyvastaukset.

SKS Kansanrunousarkisto, kalendaarikortisto ja Pääsiäiskysely 1992.

Here is the form:


<div style="background-color:Khaki; padding:10px">You tried to add an element without a name. Please give the element a descriptive name and then click “Create or edit”. If this page already exists, you will be sent to the form for editing that page. Otherwise, you will be sent to the form for adding the page.</div>


<div id="wikiPreview" style="display: none; padding-bottom: 25px; margin-bottom: 25px; border-bottom: 1px solid #AAAAAA;"></div>
<div style="max-width:60ex">__NOTOC__ __NOEDITSECTION__
{{{for template|Ilmiö}}}
{{{field|kansallinen|restricted|input type=checkbox}}} {{Mediawiki:Akp-ilmiö-kansallinen/en}} (only an administrator can change)

=== Categories ===
Choose one or more of the categories below.

{{{field|kategoria|input type=listbox|values=Esittävät taiteet,Juhlat ja tavat,Käsityötaidot,Luonto ja maailmankaikkeus,Musiikki ja tanssi,Pelit ja leikit,Ruokaperinteet,Suullinen perinne|mapping template=Aihealue-l10n|mandatory|list|size=8}}}

=== Location ===
Is the element attached to a certain area in Finland? You can choose Finland, regions or municipalities.
{{{field|sijainti|list|size=50|input type=tokens|values={{Paikat}}|mapping template=Paikka-l10n|existing values only}}}

=== Keywords ===
Separate keywords with commas.

{{{field|asiasanat|list|size=50|input type=tokens|values from property=Asiasananimitys}}}
{{{end template}}}

{{{standard input|free text|hidden}}}

=== Who practises the tradition or knows it well? ===
Who practises the tradition or knows it well? What kind of communities actively practise the tradition nowadays? Are there NGOs or other organisations related to the element? (500–2000 characters)
{{{section|Practitioners and people who know the tradition well|input type=textarea|rows=5|cols=50|autogrow}}}

=== How is the tradition practised? ===
This section should contain the primary description of the element. How is the tradition practiced today? Are there different versions of it? (500–4000 characters)
{{{section|Practising of the tradition|input type=textarea|rows=5|cols=50|autogrow}}}

=== Describe the background and history of the tradition. ===
Please mention the sources in the links section. (500–4000 characters)
{{{section|The background and history of the tradition|input type=textarea|rows=5|cols=50|autogrow}}}

=== How does the transmission of the tradition take place? ===
How is it passed from one generation or community to another? (500–4000 characters)
{{{section|The transmission of the tradition|input type=textarea|rows=5|cols=50|autogrow}}}

=== How does the future of the tradition look like? ===
How is the tradition developing? You can also mention good practices for transmission (e.g. courses or projects). (500–2000 characters)
{{{section|The future of the tradition|input type=textarea|rows=5|cols=50|autogrow}}}

=== The community/communities behind this submission ===
What is/are the community/communities behind this submission?
{{{section|The community/communities behind this submission.|input type=textarea|rows=5|cols=50|autogrow}}}

=== Bibliography and links to external sources of information ===
Add a short description before of the link.
{{{section|Bibliography and links to external sources of information|input type=textarea|rows=5|cols=50|autogrow}}}

{{{standard input|watch}}}

{{{standard input|save}}} {{{standard input|preview}}}

{{int:Copyrightwarning||CC BY 4.0}}

Git bisect says it started with 8b942f93c6abbece3ec1dc152910b25bb4e43454

Event Timeline

@Nikerabbit - I believe this is fixed now; it would be great if you could test it.

I'm planning to test later this week, I will close this task if it works.

Yaron_Koren claimed this task.

I'm setting this to "Resolved", because I think it's been fixed - feel free to re-open if not.

I confirm that with 4.9.2 the infinite loop does not happen.