Page MenuHomePhabricator

openstack-browser should forget about role associations of deleted projects
Open, LowPublic

Description

openstack-browser shows which projects and instances use specific puppet classes.

That feature is really useful and used on a regularly basis.

If a project is deleted though it does not seem to forget about a role being used in it.

Example:

https://openstack-browser.toolforge.org/puppetclass/role::simplelap lists

Project: sugarcrm

officetools.sugarcrm.eqiad.wmflabs

But if you click the instance name you get:

officetools.sugarcrm.eqiad.wmflabs Project: sugarcrm

Unknown server 'officetools.sugarcrm.eqiad.wmflabs'. Are you just guessing?

Arturo has confirmed the project sugarcrm has been deleted and said:

< arturo> in this case, I think it should forget about that particular role-->instance association
< arturo> it already forgot about the project and the instance, but no the role association

Event Timeline

Dzahn created this task.May 8 2020, 4:22 PM
Restricted Application edited projects, added cloud-services-team (Kanban); removed cloud-services-team. · View Herald TranscriptMay 8 2020, 4:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Andrew triaged this task as Medium priority.May 19 2020, 5:54 PM
Andrew claimed this task.Jun 2 2020, 4:32 PM

Change 601825 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] cloud puppet api: add a route to get a list of projects

https://gerrit.wikimedia.org/r/601825

Change 601825 merged by Andrew Bogott:
[operations/puppet@production] cloud puppet api: add a route to get a list of projects

https://gerrit.wikimedia.org/r/601825

Change 601896 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] wmcs-novastats-puppetleaks: clean up prefixes for delete projects

https://gerrit.wikimedia.org/r/601896

Change 601896 merged by Andrew Bogott:
[operations/puppet@production] wmcs-novastats-puppetleaks: clean up prefixes for delete projects

https://gerrit.wikimedia.org/r/601896

Andrew added a comment.Jun 3 2020, 5:17 PM

This has been cleaned up for the moment. The proper fix is to add a cleanup stage in wmfkeystonehooks but for now this can be addressed via periodic runs of wmcs-novastats-puppetleaks --delete.

Andrew removed Andrew as the assignee of this task.Jun 3 2020, 5:18 PM
Andrew lowered the priority of this task from Medium to Low.
Andrew added a subscriber: Andrew.
Dzahn awarded a token.Jun 3 2020, 5:40 PM