Maniphest T252246

Borrow functionality from the LinkHandlerUtils::figureHandler for serializing media in gallery
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	May 8 2020, 8:35 PM

Tags

Referenced Files

None

Subscribers

Description

A bunch of common functionality could be reused in the gallery to avoid all the roundtripping dirtying we're seeing.

See all the FIXMEs in Gallery::contentHandler,
https://github.com/wikimedia/parsoid/blob/master/src/Ext/Gallery/Gallery.php#L258

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.19.0-a4	mediawiki/vendor	master	+196 -253
	Reuse LinkHandlerUtils::figureHandler in gallery	mediawiki/services/parsoid	master	+85 -184
	Bump parsoid to 0.17.0-a19	mediawiki/vendor	master	+444 -500
	Roundtrip file prefix in galleries	mediawiki/services/parsoid	master	+73 -28
	Bump parsoid to 0.16.0-a8	mediawiki/vendor	master	+1 K -664
	Add an html/parsoid section to a test, "File with link to page section"	mediawiki/services/parsoid	master	+6 -0
	Sync parserTests files with core	mediawiki/services/parsoid	master	+280 -72

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T252246 Borrow functionality from the LinkHandlerUtils::figureHandler for serializing media in gallery
		Resolved		Arlolra	T214601 Gallery media is erroneously using sub-typeof if format is supplied
		Resolved		Arlolra	T214603 "thumbtime", "page" is lost when roundtripping in gallery
		Open		None	T211895 Visual editor shouldn't add the File: prefix when missing in a gallery
		Declined		Arlolra	T151367 Investigate the usage of gallery image syntax before enabling HTML editing

Event Timeline

Arlolra created this task.May 8 2020, 8:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2020, 8:35 PM

Arlolra triaged this task as Medium priority.May 8 2020, 8:35 PM

Arlolra added a subtask: T214601: Gallery media is erroneously using sub-typeof if format is supplied.

Arlolra added a subtask: T214603: "thumbtime", "page" is lost when roundtripping in gallery.

Arlolra added subtasks: T211895: Visual editor shouldn't add the File: prefix when missing in a gallery, T151367: Investigate the usage of gallery image syntax before enabling HTML editing.

Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.May 8 2020, 8:38 PM

There's a list of gallery normalizations in T211895#4906428

cscott mentioned this in T262833: Refactor Link handling out of <figure> handling.Sep 14 2020, 4:50 PM

ssastry moved this task from Missing Functionality to Tech Debt / Big changes on the Parsoid board.Nov 19 2020, 7:11 PM

Arlolra mentioned this in T233252: Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage.Jan 14 2021, 6:19 PM

Change 791093 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Sync parserTests files with core

https://gerrit.wikimedia.org/r/791093

gerritbot added a project: Patch-For-Review.May 11 2022, 10:02 PM

Change 791093 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Sync parserTests files with core

https://gerrit.wikimedia.org/r/791093

Change 791095 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add an html/parsoid section to a test, "File with link to page section"

https://gerrit.wikimedia.org/r/791095

Change 791095 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add an html/parsoid section to a test, "File with link to page section"

https://gerrit.wikimedia.org/r/791095

Maintenance_bot removed a project: Patch-For-Review.May 11 2022, 11:32 PM

Change 792236 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a8

https://gerrit.wikimedia.org/r/792236

gerritbot added a project: Patch-For-Review.May 16 2022, 4:06 PM

Change 792236 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a8

https://gerrit.wikimedia.org/r/792236

Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 6:32 PM

Arlolra closed subtask T214601: Gallery media is erroneously using sub-typeof if format is supplied as Resolved.Jun 28 2022, 9:26 PM

Change 891924 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Roundtrip file prefix in galleries

https://gerrit.wikimedia.org/r/891924

gerritbot added a project: Patch-For-Review.Feb 24 2023, 10:59 PM

Change 891924 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Roundtrip file prefix in galleries

https://gerrit.wikimedia.org/r/891924

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 8:11 PM

Change 894720 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a19

https://gerrit.wikimedia.org/r/894720

gerritbot added a project: Patch-For-Review.Mar 6 2023, 7:49 PM

Change 894720 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a19

https://gerrit.wikimedia.org/r/894720

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2023, 8:10 PM

Arlolra mentioned this in T333907: Address semantic differences from enabling nativeGalleryEnabled.Apr 4 2023, 12:14 AM

Arlolra claimed this task.Oct 19 2023, 10:59 PM

Change 967323 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Reuse LinkHandlerUtils::figureHandler in gallery

https://gerrit.wikimedia.org/r/967323

gerritbot added a project: Patch-For-Review.Oct 20 2023, 12:32 AM

Arlolra added projects: Content-Transform-Team-WIP, Maintenance-Worktype.Oct 20 2023, 12:32 AM

Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.

Change 967323 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Reuse LinkHandlerUtils::figureHandler in gallery

https://gerrit.wikimedia.org/r/967323

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2023, 10:10 PM

Arlolra moved this task from In Progress to To Deploy on the Content-Transform-Team-WIP board.Oct 23 2023, 10:11 PM

Change 969688 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a4

https://gerrit.wikimedia.org/r/969688

gerritbot added a project: Patch-For-Review.Oct 30 2023, 9:57 AM

Change 969688 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a4

https://gerrit.wikimedia.org/r/969688

MSantos moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Mon, Nov 13, 4:21 PM

Maintenance_bot removed a project: Patch-For-Review.Mon, Nov 13, 4:30 PM

ssastry closed this task as Resolved.Mon, Nov 20, 7:50 PM

VPuffetMichel closed subtask T214603: "thumbtime", "page" is lost when roundtripping in gallery as Resolved.Mon, Dec 4, 6:40 PM